[jira] Updated: (POOL-155) ObjectPool.invalidateObject(object) should throw an Exception if object is null

["Phil Steitz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/POOL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated POOL-155:
-----------------------------

    Fix Version/s: 2.0
                       (was: 1.5.5)

The javadoc updates in r952050 clarify the 1.x contract.  I don't think there is anything more we should do with this until 2.0, where we can modify the pool client and factory contracts as necessary.

> ObjectPool.invalidateObject(object) should throw an Exception if object is null
> -------------------------------------------------------------------------------
>
>                 Key: POOL-155
>                 URL: https://issues.apache.org/jira/browse/POOL-155
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.2, 1.3, 1.4, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4
>            Reporter: Sebb
>             Fix For: 2.0
>
>
> ObjectPool.invalidateObject(object) should throw an Exception if object is null, otherwise the numActive count can get out of synch.
> It's easy to do this by mistake, see:
> http://markmail.org/thread/ya22ihmghejbfzme
> Also, the documentation for ObjectPool needs to be updated to clarify that invalidateObject should only be called if the object failed, not the borrow.
> [I'll do this shortly]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.