You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/12 00:31:12 UTC

[GitHub] [flink-statefun] sjwiesman commented on pull request #274: [FLINK-22533] Add custom metrics

sjwiesman commented on pull request #274:
URL: https://github.com/apache/flink-statefun/pull/274#issuecomment-940558983


   The general implementation looks good.
   
   My only comment is on the API. It feels strange to me that we have `FunctionTypeScopedMetrics` and `RouterMetrics` as two separate interfaces. Could we unify them into one interface? 
   
   I also really like the cleanup of `LocalFunctionGroup`, that whole part of the codebase is much easier to follow :) 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org