[GitHub] [spark] cloud-fan commented on a change in pull request #28540: [SPARK-31719][SQL] Refactor JoinSelection

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #28540:
URL: https://github.com/apache/spark/pull/28540#discussion_r429927305



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -208,3 +208,161 @@ object ExtractPythonUDFFromJoinCondition extends Rule[LogicalPlan] with Predicat
       }
   }
 }
+
+sealed abstract class BuildSide
+
+case object BuildRight extends BuildSide
+
+case object BuildLeft extends BuildSide
+
+trait JoinSelectionHelper {
+
+  def getBroadcastBuildSide(
+      left: LogicalPlan,
+      right: LogicalPlan,
+      joinType: JoinType,
+      hint: JoinHint,
+      onlyLookingAtHint: Boolean,

Review comment:
       If we want to be super clear, maybe "pickJoinSideByHintOnly"? or simply "hintOnly".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org