[GitHub] [incubator-superset] simchaNielsen commented on a change in pull request #12147: [WIP] chore(explore): remove dedicated time section

[GitBox <gi...@apache.org>]

simchaNielsen commented on a change in pull request #12147:
URL: https://github.com/apache/incubator-superset/pull/12147#discussion_r546412027



##########
File path: superset-frontend/src/explore/controlUtils.js
##########
@@ -193,20 +193,25 @@ const getMemoizedSectionsToRender = memoizeOne(
       }
     });
 
-    const { datasourceAndVizType, sqlaTimeSeries, druidTimeSeries } = sections;
-    const timeSection =
-      datasourceType === 'table' ? sqlaTimeSeries : druidTimeSeries;
+    const { datasourceAndVizType } = sections;
+    // list of datasource-specific controls that should be removed
+    const invalidControls =

Review comment:
       I saw in attached PR #869 also `time_range`, shouldn't be it here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org