Re: [PR] [SPARK-45534][CORE] Use java.lang.ref.Cleaner instead of finalize for RemoteBlockPushResolver [spark]

["beliefer (via GitHub)" <gi...@apache.org>]

beliefer commented on code in PR #43371:
URL: https://github.com/apache/spark/pull/43371#discussion_r1360011335


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1933,6 +1946,29 @@ public RoaringBitmap getMapTracker() {
     int getNumIOExceptions() {
       return numIOExceptions;
     }
+
+    AppAttemptShuffleMergeId getAppAttemptShuffleMergeId() {
+      return appAttemptShuffleMergeId;
+    }
+
+    int getReduceId() {
+      return reduceId;
+    }
+
+    private record ResourceCleaner(
+        File dataFile,
+        FileChannel dataChannel,
+        MergeShuffleFile indexFile,
+        MergeShuffleFile metaFile,
+        AppAttemptShuffleMergeId appAttemptShuffleMergeId,
+        int reduceId) implements Runnable {

Review Comment:
   Why not change the constructor accpets `AppShufflePartitionInfo`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org