You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2023/06/16 22:28:44 UTC

[GitHub] [superset] mistercrunch opened a new pull request, #24437: chore: toning down grayscale on X icon

mistercrunch opened a new pull request, #24437:
URL: https://github.com/apache/superset/pull/24437

   Cosmetics! Here's the after ->
   <img width="992" alt="Screen Shot 2023-06-16 at 3 27 06 PM" src="https://github.com/apache/superset/assets/487433/0c187bd3-22d7-4fd6-9e28-2f25698d2d5d">
   
   From another env, this should help ->
   <img width="536" alt="Screen Shot 2023-06-16 at 3 28 08 PM" src="https://github.com/apache/superset/assets/487433/fa66b564-b037-4c86-b0ae-ba70895911be">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas merged pull request #24437: chore: toning down grayscale on X icon

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #24437:
URL: https://github.com/apache/superset/pull/24437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #24437: chore: toning down grayscale on X icon

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24437:
URL: https://github.com/apache/superset/pull/24437#issuecomment-1595473481

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24437?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#24437](https://app.codecov.io/gh/apache/superset/pull/24437?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9f5e910) into [master](https://app.codecov.io/gh/apache/superset/commit/20e00363365780c37fefe60311321c41a81c5ee9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (20e0036) will **not change** coverage.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 9f5e910 differs from pull request most recent head f941ee1. Consider uploading reports for the commit f941ee1 to get more accurate results
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #24437   +/-   ##
   =======================================
     Coverage   68.93%   68.93%           
   =======================================
     Files        1904     1904           
     Lines       73879    73879           
     Branches     8119     8119           
   =======================================
     Hits        50928    50928           
     Misses      20840    20840           
     Partials     2111     2111           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `55.65% <100.00%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/pages/DatabaseList/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFiYXNlTGlzdC9pbmRleC50c3g=) | `65.45% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org