[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #665: Fixes SOLR-13539

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r319118987
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
 ##########
 @@ -429,7 +434,18 @@ public SolrInputDocument readDoc(XMLStreamReader parser) throws XMLStreamExcepti
             break;
           } else if ("field".equals(parser.getLocalName())) {
             // should I warn in some text has been found too
-            Object v = isNull ? null : text.toString();
+            Object v;
 
 Review comment:
   Hey @thomaswoeckinger what's the purpose of this change here?  I gather it's allowing the XMLLoader to handle a binary base64 content-type, but was that required for a particular test change?  Is it something needed by EmbeddedSolrServer?  Something else?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org