[GitHub] [calcite] zstan commented on a diff in pull request #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL

["zstan (via GitHub)" <gi...@apache.org>]

zstan commented on code in PR #3211:
URL: https://github.com/apache/calcite/pull/3211#discussion_r1214203114


##########
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##########
@@ -1042,6 +1042,10 @@ void testDyadicCollateOperator() {
         .columnType("VARCHAR(1) NOT NULL");
     expr("substring('a', 1, '3')")
         .columnType("VARCHAR(1) NOT NULL");
+
+    expr("SUBSTRING(NULL FROM 1 FOR 2)").ok();

Review Comment:
   @herunkang2018 fixed, can you make a review plz ? I update description and starting code point in appropriate issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org