You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2017/02/11 07:37:30 UTC
Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1321
https://issues.apache.org/jira/browse/RANGER-1321
Repository: ranger
Description
-------
RANGER-1321:Provide a mechanism to create service-specific default policies
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
security-admin/pom.xml 0fcfc5a
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
Diff: https://reviews.apache.org/r/56571/diff/
Testing
-------
Test in Local VM
Thanks,
Ramesh Mani
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/#review166305
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java (line 124)
<https://reviews.apache.org/r/56571/#comment238239>
Consider marking this method as private, as we don't expect the implementations to override or call this one.
Review other helper methods as well.
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java (line 142)
<https://reviews.apache.org/r/56571/#comment238241>
Consider moving line #142 inside createDefaultPolicyItem() method - as the method has access to 'service' config, from which the userList is derived.
- Madhan Neethiraj
On Feb. 18, 2017, 2:06 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56571/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 2:06 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1321
> https://issues.apache.org/jira/browse/RANGER-1321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1321:Provide a mechanism to create service-specific default policies
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java 3940154
> plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 8b41ae3
> security-admin/pom.xml 0fcfc5a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
>
> Diff: https://reviews.apache.org/r/56571/diff/
>
>
> Testing
> -------
>
> Test in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/#review167552
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java
Lines 202 (patched)
<https://reviews.apache.org/r/56571/#comment239431>
Please consider not having any service-type of service specific code in this class. All Service-Type or service specific code needs to be in the specific subclass of RangerServiceBase (such as RangerServiceTag, RangerServiceHdfs, RangerServiceKMS, RangerServiceYarn).
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 3809 (patched)
<https://reviews.apache.org/r/56571/#comment239430>
Please consider having no code specific to Service-type or Service for which default policies are being created in this class. Ideally, this class should concern itself only with managing datastore for Ranger objects.
- Abhay Kulkarni
On Feb. 24, 2017, 8:19 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56571/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:19 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1321
> https://issues.apache.org/jira/browse/RANGER-1321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1321:Provide a mechanism to create service-specific default policies
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java 3940154
> plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 8b41ae3
> security-admin/pom.xml 0fcfc5a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
>
>
> Diff: https://reviews.apache.org/r/56571/diff/3/
>
>
> Testing
> -------
>
> Test in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 8:19 a.m.)
Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Bugs: RANGER-1321
https://issues.apache.org/jira/browse/RANGER-1321
Repository: ranger
Description
-------
RANGER-1321:Provide a mechanism to create service-specific default policies
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java 3940154
plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 8b41ae3
security-admin/pom.xml 0fcfc5a
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
Diff: https://reviews.apache.org/r/56571/diff/
Testing
-------
Test in Local VM
Thanks,
Ramesh Mani
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/
-----------------------------------------------------------
(Updated Feb. 18, 2017, 2:06 a.m.)
Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Review comment fixed
Bugs: RANGER-1321
https://issues.apache.org/jira/browse/RANGER-1321
Repository: ranger
Description
-------
RANGER-1321:Provide a mechanism to create service-specific default policies
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java 3940154
plugin-kms/src/main/java/org/apache/ranger/services/kms/RangerServiceKMS.java 8b41ae3
security-admin/pom.xml 0fcfc5a
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
Diff: https://reviews.apache.org/r/56571/diff/
Testing
-------
Test in Local VM
Thanks,
Ramesh Mani
Re: Review Request 56571: RANGER-1321:Provide a mechanism to create
service-specific default policies
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56571/#review165855
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 1448)
<https://reviews.apache.org/r/56571/#comment237683>
instantiation of 'defaultRangerPolicies' (line #1448) can go inside the 'if' block at line #1453.
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 3805)
<https://reviews.apache.org/r/56571/#comment237703>
Is this method supposed to add certain configured users/groups to all policy items in default policies? The implementation seems to do a lot more; please review and simplify.
- Madhan Neethiraj
On Feb. 11, 2017, 7:37 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56571/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 7:37 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1321
> https://issues.apache.org/jira/browse/RANGER-1321
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-1321:Provide a mechanism to create service-specific default policies
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 73027a0
> security-admin/pom.xml 0fcfc5a
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java cb67b6a
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 2b773da
>
> Diff: https://reviews.apache.org/r/56571/diff/
>
>
> Testing
> -------
>
> Test in Local VM
>
>
> Thanks,
>
> Ramesh Mani
>
>