You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Robert Metzger (JIRA)" <ji...@apache.org> on 2015/12/07 16:54:10 UTC
[jira] [Commented] (FLINK-2963) Dependence on
SerializationUtils#deserialize() should be avoided
[ https://issues.apache.org/jira/browse/FLINK-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045112#comment-15045112 ]
Robert Metzger commented on FLINK-2963:
---------------------------------------
I see. My check was only there for commons.lang, not for commons.lang3. I extended the check in commit: http://git-wip-us.apache.org/repos/asf/flink/commit/868f97cf
The {{JavaDefautlStringSchema}} has been removed.
Our checkstyle is only checking code in {{src/main/}}, not in {{src/test/}}, that's why the usage in {{MockOutput}} was not found. I think its not a critical issue to use the SerializationUtils for test cases.
I'll close the issue.
> Dependence on SerializationUtils#deserialize() should be avoided
> ----------------------------------------------------------------
>
> Key: FLINK-2963
> URL: https://issues.apache.org/jira/browse/FLINK-2963
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Robert Metzger
> Priority: Minor
> Fix For: 1.0.0
>
>
> There is a problem with `SerializationUtils` from Apache Commons
> Lang. Here is an open issue where the class will throw a
> `ClassNotFoundException` even if the class is in the classpath in a
> multiple-classloader environment:
> https://issues.apache.org/jira/browse/LANG-1049
> {code}
> state = (HashMap<String, Serializable>) SerializationUtils.deserialize(bais);
> ./flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/NonKeyedWindowOperator.java
> state = (HashMap<String, Serializable>) SerializationUtils.deserialize(bais);
> ./flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
> return SerializationUtils.deserialize(message);
> ./flink-streaming-java/src/main/java/org/apache/flink/streaming/util/serialization/JavaDefaultStringSchema.java
> T copied = SerializationUtils.deserialize(SerializationUtils
> ./flink-streaming-java/src/test/java/org/apache/flink/streaming/util/MockOutput.java
> {code}
> We should move away from SerializationUtils.deserialize()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)