[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5168: Refactor DistinctQueriesTest to cover more scenarios

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5168: Refactor DistinctQueriesTest to cover more scenarios
URL: https://github.com/apache/incubator-pinot/pull/5168#discussion_r401189152
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/DistinctDataTableReducer.java
 ##########
 @@ -108,7 +108,7 @@ public void reduceAndSetResults(String tableName, DataSchema dataSchema,
       if (mergedIntermediateResult == null) {
         mergedIntermediateResult = intermediateResultToMerge;
       } else {
-        _aggregationFunction.merge(mergedIntermediateResult, intermediateResultToMerge);
+        mergedIntermediateResult = _aggregationFunction.merge(mergedIntermediateResult, intermediateResultToMerge);
 
 Review comment:
   IIUC, this is needed because for the case of empty, it may return a new object as opposed to merging into existing ones?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org