[GitHub] [nuttx-apps] lupyuen commented on pull request #1341: LVGL v8 upgrade

[GitBox <gi...@apache.org>]

lupyuen commented on PR #1341:
URL: https://github.com/apache/nuttx-apps/pull/1341#issuecomment-1374987956

   Hi @FASTSHIFT thanks for adding LVGL 8 support! I have a question: Should we insert `lv_tick_inc()` into the LVGL Task Loop, like this?
   
   From [lvgldemo.c](https://github.com/apache/nuttx-apps/blob/master/examples/lvgldemo/lvgldemo.c#L213-L227):
   
   ```c
     /* Handle LVGL tasks */
     while (1)
       {
         uint32_t idle;
         idle = lv_timer_handler();
   
         /* Minimum sleep of 1ms */
         idle = idle ? idle : 1;
         usleep(idle * 1000);
   
         // Inserted this: Increment LVGL Tick Count by 1 millisecond
         lv_tick_inc(1);
       }
   ```
   
   __Before Adding `lv_tick_inc()`__: When we run `lvgldemo` on PINE64 PinePhone, the app doesn't read touch input from `/dev/input0`.
   
   Also the LVGL Log shows: `It seems lv_tick_inc() is not called`
   
   __After Adding `lv_tick_inc()`__: `lvgldemo` on PinePhone correctly handles the touch input.  [(See this)](https://www.youtube.com/shorts/xE9U5IQPmlg)
   
   I'm not sure if my parameter to `lv_tick_inc()` is correct. Maybe we need to compute the actual elapsed milliseconds using the System Timer? This might help to reduce the lag that we see in the [demo video](https://www.youtube.com/shorts/xE9U5IQPmlg).
   
   Thanks for looking into this :-)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org