You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/09 17:58:39 UTC

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5756: make dtype="float" mean float32 for relay.expr.const

comaniac commented on a change in pull request #5756:
URL: https://github.com/apache/incubator-tvm/pull/5756#discussion_r437616610



##########
File path: python/tvm/relay/expr.py
##########
@@ -487,6 +487,8 @@ def const(value, dtype=None):
     - bool maps to "bool"
     - other using the same default rule as numpy.
     """
+    if dtype == 'float': # for numpy, float is float64, for us it is float32
+        dtype = 'float32'

Review comment:
       Can this be merged to L496-502?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org