You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2022/07/30 19:55:38 UTC
[GitHub] [tika] TheHound opened a new pull request, #626: [TIKA-3825] ForkClient to check for thread interrupted status when waiting for response
TheHound opened a new pull request, #626:
URL: https://github.com/apache/tika/pull/626
ForkClient to check for thread interrupted status when waiting for response. Add test to ForkParserTest to demonstrate issue and fix.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #626: [TIKA-3825] ForkClient to check for thread interrupted status when waiting for response
Posted by GitBox <gi...@apache.org>.
tballison commented on PR #626:
URL: https://github.com/apache/tika/pull/626#issuecomment-1201690999
Thank you @TheHound!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison merged pull request #626: [TIKA-3825] ForkClient to check for thread interrupted status when waiting for response
Posted by GitBox <gi...@apache.org>.
tballison merged PR #626:
URL: https://github.com/apache/tika/pull/626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #626: [TIKA-3825] ForkClient to check for thread interrupted status when waiting for response
Posted by GitBox <gi...@apache.org>.
tballison commented on PR #626:
URL: https://github.com/apache/tika/pull/626#issuecomment-1201211957
This looks great. Are you able to fix the two checkstyle violations?
```
Error: src/test/java/org/apache/tika/fork/ForkTestParser.java:[76,46] (blocks) EmptyCatchBlock: Empty catch block.
Error: src/test/java/org/apache/tika/fork/ForkParserTest.java:[47,8] (imports) UnusedImports: Unused import - java.util.concurrent.Future.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] TheHound commented on pull request #626: [TIKA-3825] ForkClient to check for thread interrupted status when waiting for response
Posted by GitBox <gi...@apache.org>.
TheHound commented on PR #626:
URL: https://github.com/apache/tika/pull/626#issuecomment-1201441334
Yeah sorry about that will amend that commit now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org