[jira] [Resolved] (AIRFLOW-580) Disable Logging String Formatting Style Warning in Landscape.io

["Siddharth Anand (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siddharth Anand resolved AIRFLOW-580.
-------------------------------------
    Resolution: Fixed

Issue resolved by pull request #1843
[https://github.com/apache/incubator-airflow/pull/1843]

> Disable Logging String Formatting Style Warning in Landscape.io
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-580
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-580
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: logging
>         Environment: CI
>            Reporter: Robin Miller
>            Assignee: Robin Miller
>            Priority: Trivial
>              Labels: CI
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> After a change relating to logging, the Landscape.io formatting checks produced the warning: "Use % formatting in logging functions and pass the % parameters as arguments"
> This occurred on any lines of the form:
> _log.info("Some string with {} in".format(variable))
> After a look around the code to identify the norm, it seems there are a lot of lines like this. Discussion on the dev email list brought up the following points:
> - New style formatting is preferred for reading code.
> - Old style formatting allows for a slight performance gain in the situation where the log message is ignored due to the logging level, as it can skip interpolation.
> - This performance gain is likely to be very small for our use case.
> As such I propose the addition of "logging-format-interpolation" to the pylint disable list in the .landscape.yml file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)