You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/22 13:37:55 UTC

[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #86: [Enhancement] Optimized fast_path_match()

kezhenxu94 commented on a change in pull request #86:
URL: https://github.com/apache/skywalking-python/pull/86#discussion_r528336896



##########
File path: skywalking/utils/ant_matcher.py
##########
@@ -16,75 +16,24 @@
 #
 
 
-def fast_path_match(pattern: str, path: str):

Review comment:
       This is ported from a Java version, I've just run a simple benchmark test, regex is much more better then the original version, thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org