[GitHub] [spark] zhengruifeng commented on a diff in pull request #38621: [SPARK-41111][CONNECT][PYTHON] Implement `DataFrame.show`

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #38621:
URL: https://github.com/apache/spark/pull/38621#discussion_r1020987941


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -253,6 +254,23 @@ message Repartition {
   bool shuffle = 3;
 }
 
+// Compose the string representing rows for output.
+// It will invoke 'Dataset.showString' to compute the results.
+message ShowString {
+  // (Required). The input relation.
+  Relation input = 1;
+
+  // (Required) Number of rows to show.

Review Comment:
   I prefer to make it `required` here.
   we can not invoke the `show` methods since they just print and return Unit.
   to get a string, we need to invoke `showString` which requires all the parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org