You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2019/09/10 12:42:17 UTC
[GitHub] [incubator-dlab] bhliva commented on a change in pull request #294:
[DLAB-1054]: Added possibility to retrieve custom images per project
bhliva commented on a change in pull request #294: [DLAB-1054]: Added possibility to retrieve custom images per project
URL: https://github.com/apache/incubator-dlab/pull/294#discussion_r322718814
##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/resources/ImageExploratoryResource.java
##########
@@ -80,9 +80,10 @@ public Response createImage(@ApiParam(hidden = true) @Auth UserInfo ui,
@ApiResponses(@ApiResponse(code = 200, message = "Machine images were fetched successfully"))
public Response getImages(@ApiParam(hidden = true) @Auth UserInfo ui,
@ApiParam(value = "Docker image", required = true)
- @QueryParam("docker_image") String dockerImage) {
- log.debug("Getting images for user " + ui.getName());
- final List<ImageInfoRecord> images = imageExploratoryService.getNotFailedImages(ui.getName(), dockerImage);
+ @QueryParam("docker_image") String dockerImage,
+ @QueryParam("project") String project) {
Review comment:
Please add swagger annotation for this param
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org