You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by kfeagle <gi...@git.apache.org> on 2017/06/25 06:14:29 UTC
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
GitHub user kfeagle opened a pull request:
https://github.com/apache/incubator-weex/pull/468
Ios bugfix mamaca 0.14 dev 0624
Ios bugfix mamaca
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kfeagle/incubator-weex ios-bugfix-mamaca-0.14-dev-0624
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/468.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #468
----
commit 41cd8dcc53b89401fa15434a83474ed2c080d993
Author: 齐山 <su...@163.com>
Date: 2017-06-24T10:21:03Z
+ [example] macaca modify
commit f4b0b46fa8ef470f8d02044c4049a91fb5ccdc03
Author: 齐山 <su...@163.com>
Date: 2017-06-24T10:59:43Z
+ [example] update maraca
commit f60456cbce41d2c00a98d6b7ea0f7fd6a01e78a5
Author: 齐山 <su...@163.com>
Date: 2017-06-24T11:05:45Z
+ [example] revert to before
commit 1a0813a653259c1b48e4ec83df6ebf655b8b917d
Author: 齐山 <su...@163.com>
Date: 2017-06-24T12:15:52Z
+ [example] fix bug toast refect input
commit 8ddc04bc3860b6c33eec27ce447e071439aea0b1
Author: 齐山 <su...@163.com>
Date: 2017-06-24T12:43:08Z
+ [example] update logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/468#discussion_r123918323
--- Diff: test/pages/components/textarea-maxlength.vue ---
@@ -16,17 +16,17 @@
oninput (event) {
this.value = event.value
console.log('oninput:', event.value)
- modal.toast({
- message: `oninput: ${event.value}`,
- duration: 0.8
- })
+// modal.toast({
--- End diff --
1. Why remove this?
2. Just remove it, not comment it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/468#discussion_r123918490
--- Diff: test/scripts/components/textarea-maxlength.test.js ---
@@ -43,11 +43,13 @@ describe('@ignore-android textarea maxlength vue test2 ', function () {
return driver
.elementById('textarea')
.sendKeys('12345678')
- .sleep(2000)
+ .sleep(3000)
+ .source()
--- End diff --
What it this? 'Get the current page source.' according to the doc https://macacajs.github.io/macaca-wd/#source
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/468#discussion_r123918517
--- Diff: test/scripts/util.js ---
@@ -194,7 +194,7 @@ module.exports = {
return driver.status()
else{
driver._isInit = true;
- return driver.initDriver()
+ return driver.initDriver().sleep(20000)
--- End diff --
Every time require this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/468#discussion_r124175344
--- Diff: test/scripts/components/textarea-maxlength.test.js ---
@@ -43,11 +43,13 @@ describe('@ignore-android textarea maxlength vue test2 ', function () {
return driver
.elementById('textarea')
.sendKeys('12345678')
- .sleep(2000)
+ .sleep(3000)
+ .source()
--- End diff --
this will display all element . user can gain the message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #468: Ios bugfix mamaca 0.14 dev 0624
Posted by kfeagle <gi...@git.apache.org>.
Github user kfeagle commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/468#discussion_r123891236
--- Diff: test/scripts/util.js ---
@@ -194,7 +194,7 @@ module.exports = {
return driver.status()
else{
driver._isInit = true;
- return driver.initDriver()
+ return driver.initDriver().sleep(20000)
--- End diff --
driver 启动后等待20s，然后再探测，否则crash
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---