You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/20 09:49:38 UTC
[GitHub] [inlong] yunqingmoswu opened a new pull request, #6244: [INLONG-6243][Sort] Add custom name for sort job
yunqingmoswu opened a new pull request, #6244:
URL: https://github.com/apache/inlong/pull/6244
### Prepare a Pull Request
*(Change the title refer to the following example)*
Title: [INLONG-6243][Sort] Add custom name for sort job
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
Fixes #6243
### Motivation
Add custom name for sort job, if it is not specified, it will be 'InLong-Sort-Job'.
### Modifications
1. Add job name setting with 'org.apache.inlong.sort.Entrance'
2. Add JOB_NAME constant for 'org.apache.inlong.sort.configuration.Constants'
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [x] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #6244: [INLONG-6243][Sort] Add custom name for sort job
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #6244:
URL: https://github.com/apache/inlong/pull/6244#discussion_r1000413351
##########
inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/Entrance.java:
##########
@@ -52,6 +52,7 @@ public static void main(String[] args) throws Exception {
EnvironmentSettings settings = EnvironmentSettings.newInstance().useBlinkPlanner()
.inStreamingMode().build();
StreamTableEnvironment tableEnv = StreamTableEnvironment.create(env, settings);
+ tableEnv.getConfig().getConfiguration().setString("pipeline.name", config.getString(Constants.JOB_NAME));
Review Comment:
All string in entrance are extracted as constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6244: [INLONG-6243][Sort] Support custom name for Sort job
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6244:
URL: https://github.com/apache/inlong/pull/6244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org