You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/12 16:16:46 UTC
[jira] [Commented] (CLOUDSTACK-8302) Cleanup snapshot on KVM with
RBD
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15054348#comment-15054348 ]
ASF GitHub Bot commented on CLOUDSTACK-8302:
--------------------------------------------
GitHub user dmytro-shevchenko opened a pull request:
https://github.com/apache/cloudstack/pull/1230
CLOUDSTACK-8302: Removing snapshots on RBD
Snapshot removing implemented if primary datastore is RBD
https://issues.apache.org/jira/browse/CLOUDSTACK-8302
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SafeSwissCloud/cloudstack CLOUDSTACK-8302
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1230
----
commit 32df243422d5985c8631686a0b2a29835f804079
Author: Amin <am...@gmail.com>
Date: 2015-11-30T13:39:50Z
Merge pull request #1 from apache/master
Volume snapshot lifecycle patch on RBD as primary storage
commit c4d749f3b41090c47d98431aef67fa769642c798
Author: Dmytro Shevchenko <ds...@gmail.com>
Date: 2015-12-10T15:07:58Z
Merge from apache/master
commit a47b9300e414039734017fde0a41d162b54891f2
Author: Dmytro Shevchenko <ds...@gmail.com>
Date: 2015-12-12T14:44:09Z
https://issues.apache.org/jira/browse/CLOUDSTACK-8302
Snapshot removing implemented on RBD
----
> Cleanup snapshot on KVM with RBD
> --------------------------------
>
> Key: CLOUDSTACK-8302
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8302
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the default.)
> Components: KVM, Snapshot, Storage Controller
> Affects Versions: 4.4.0, 4.4.1, 4.4.2
> Environment: CloudStack 4.4.2 + KVM on CentOS 6.6 + Ceph/RBD 0.80.8
> Reporter: Star Guo
> Assignee: Wido den Hollander
> Priority: Critical
>
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
> I deploy an instance on RBD and I create the ROOT volume snapshots. When delete a snapshot the UI show OK, but the snapshot of the volume in the RBD pool is still exist.
> And I find the code in com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java:
> …
> @Override
> public Answer deleteSnapshot(DeleteCommand cmd) {
> return new Answer(cmd);
> }
> …
> deleteSnapshot() does not be implememented. And I also find the code:
> ...
> @Override
> public Answer createTemplateFromSnapshot(CopyCommand cmd) {
> return null; //To change body of implemented methods use File | Settings | File Templates.
> }
> ...
> So does createTenokateFromSnapshot(). I just look for it in MASTER branch but not do that yet. Will CloudStack Dev Team plan to do that ? Thanks .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)