You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "buhbuhtig (via GitHub)" <gi...@apache.org> on 2023/02/23 08:32:04 UTC
[GitHub] [echarts] buhbuhtig opened a new pull request, #18303: Bug Fixed: candlestick red-green
buhbuhtig opened a new pull request, #18303:
URL: https://github.com/apache/echarts/pull/18303
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [+] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Changes the colour of the candle to the correct colour: rise - green, fall - red (original bug - colours mixed up).
### Fixed issues
The colours have been swapped.
## Details
### Before: What was the problem?
A positive candle (itemStyle: color) was marked in red, a falling candle in green (itemStyle:color0).
### After: How does it behave after the fixing?
The right way: up is green, down is red.
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia closed pull request #18303: fix: candlestick red-green bug
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia closed pull request #18303: fix: candlestick red-green bug
URL: https://github.com/apache/echarts/pull/18303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #18303: fix: candlestick red-green bug
Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on PR #18303:
URL: https://github.com/apache/echarts/pull/18303#issuecomment-1442726511
Thanks for your contribution but this is not a bug.
> Different countries or regions have different implications on the color of candle stick chart. It may use red to imply increasing with red and decreasing with blue (in China mainland, Taiwan, Japan, Koera, and so on), or to imply increasing with green and decreasing with red (in Europe, North America, Hong Kong, Singapore, and so on). Besides color, the increase and decrease of stock may also be represented with candle stick with or without filling colors.
>
> We use red to represent increasing and blue decreasing by default. If you want to change the configuration, you may change the following parameters.
>
>- [series-candlestick.itemStyle.color](https://echarts.apache.org/en/option.html#series-candlestick.itemStyle.color): fill color for bullish candle stick (namely, increase)
>- [series-candlestick.itemStyle.color0](https://echarts.apache.org/en/option.html#series-candlestick.itemStyle.color0): fill color for bearish candle stick (namely, decrease)
>- [series-candlestick.itemStyle.borderColor](https://echarts.apache.org/en/option.html#series-candlestick.itemStyle.borderColor): border color for bullish candle stick (namely, increase)
>- [series-candlestick.itemStyle.borderColor0](https://echarts.apache.org/en/option.html#series-candlestick.itemStyle.borderColor0): border color for bearish candle stick (namely, decrease)
>- [series-candlestick.itemStyle.borderColorDoji](https://echarts.apache.org/en/option.html#series-candlestick.itemStyle.borderColorDoji): border color for doji (when the open price is the same as the close price)
Please checkout [the document](https://echarts.apache.org/en/option.html#series-candlestick.type) for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18303: Bug Fixed: candlestick red-green
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18303:
URL: https://github.com/apache/echarts/pull/18303#issuecomment-1441371984
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org