[GitHub] [camel-k] gansheer commented on a diff in pull request #4672: Fix: Namespace permissions in api groups

["gansheer (via GitHub)" <gi...@apache.org>]

gansheer commented on code in PR #4672:
URL: https://github.com/apache/camel-k/pull/4672#discussion_r1296769877


##########
helm/camel-k/templates/operator-role.yaml:
##########
@@ -43,6 +43,13 @@ rules:
   - patch
   - update
   - watch
+- apiGroups:
+  - ""
+  resources:
+  - namespaces
+  verbs:
+  - get
+  - list

Review Comment:
   Could you tell me is the `list` verb is needed ?
   
   Looking into the config RBAC crds I would expect: 
   * `get` 
   https://github.com/apache/camel-k/blob/5975cf3474165f60f14bdcf1c3480bc344a5ed7e/config/rbac/operator-role.yaml#L182-L187
   * `patch` to manage knative presence
   https://github.com/apache/camel-k/blob/5975cf3474165f60f14bdcf1c3480bc344a5ed7e/config/rbac/operator-role-knative.yaml#L74-L80
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org