You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/06/24 08:53:52 UTC
(superset) branch master updated: fix(dashboard): keep native filter dropdown from covering input (#40032)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 8eb753eab22 fix(dashboard): keep native filter dropdown from covering input (#40032)
8eb753eab22 is described below
commit 8eb753eab2288beba515030465d5574d1827602a
Author: felipegr0ssi <fe...@gmail.com>
AuthorDate: Wed Jun 24 01:53:44 2026 -0700
fix(dashboard): keep native filter dropdown from covering input (#40032)
Co-authored-by: feehgrossi <fe...@sptech.school>
Co-authored-by: Evan Rusackas <ev...@rusackas.com>
Co-authored-by: Claude Opus 4.8 <no...@anthropic.com>
---
.../components/Select/SelectFilterPlugin.test.tsx | 39 ++++++++++++++++++++++
.../components/Select/SelectFilterPlugin.tsx | 21 ++++++++----
2 files changed, 54 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
index 8561ff8b7a5..31f42227c10 100644
--- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
+++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
@@ -1658,3 +1658,42 @@ test('renders standard Select dropdown when operatorType is Exact', () => {
expect(screen.getAllByRole('combobox').length).toBeGreaterThan(0);
});
+
+test('renders dashboard select dropdown popup under document body', async () => {
+ jest.useFakeTimers({ advanceTimers: true });
+ render(<SelectFilterPlugin {...buildSelectFilterProps()} />, {
+ useRedux: true,
+ initialState: {
+ nativeFilters: {
+ filters: { 'test-filter': { name: 'Test Filter' } },
+ },
+ dataMask: {
+ 'test-filter': {
+ extraFormData: {
+ filters: [{ col: 'gender', op: 'IN', val: ['boy'] }],
+ },
+ filterState: {
+ value: ['boy'],
+ label: 'boy',
+ excludeFilterValues: true,
+ },
+ },
+ },
+ },
+ });
+
+ const [filterSelect] = screen.getAllByRole('combobox');
+ userEvent.click(filterSelect);
+
+ let dropdown: Element | undefined;
+ await waitFor(() => {
+ dropdown = Array.from(
+ document.querySelectorAll('.ant-select-dropdown'),
+ ).find(
+ element => !element.classList.contains('ant-select-dropdown-hidden'),
+ );
+ expect(dropdown).toBeDefined();
+ });
+
+ expect(dropdown?.parentElement).toBe(document.body);
+});
diff --git a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
index 1ebe8fad437..f2b42d26306 100644
--- a/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
+++ b/superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
@@ -539,6 +539,19 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
[debouncedLikeChange],
);
+ const getSelectPopupContainer = useCallback(
+ (trigger: HTMLElement) => {
+ if (showOverflow) {
+ return (parentRef?.current as HTMLElement) || document.body;
+ }
+ if (appSection === AppSection.FilterConfigModal) {
+ return (trigger?.parentNode as HTMLElement) || document.body;
+ }
+ return document.body;
+ },
+ [appSection, parentRef, showOverflow],
+ );
+
const likeInputPlaceholder = useMemo(() => {
switch (operatorType) {
case SelectFilterOperatorType.Contains:
@@ -571,6 +584,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
{ value: 'false', label: t('is') },
]}
onChange={handleExclusionToggle}
+ getPopupContainer={getSelectPopupContainer}
/>
)}
{isLikeOperator ? (
@@ -595,12 +609,7 @@ export default function PluginFilterSelect(props: PluginFilterSelectProps) {
allowSelectAll={!searchAllOptions}
value={multiSelect ? filterState.value || [] : filterState.value}
disabled={isDisabled}
- getPopupContainer={
- showOverflow
- ? () => (parentRef?.current as HTMLElement) || document.body
- : (trigger: HTMLElement) =>
- (trigger?.parentNode as HTMLElement) || document.body
- }
+ getPopupContainer={getSelectPopupContainer}
showSearch={showSearch}
mode={multiSelect ? 'multiple' : 'single'}
placeholder={placeholderText}