You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2017/10/18 13:07:00 UTC

[jira] [Comment Edited] (HDFS-11468) Ozone: SCM: Add Node Metrics for SCM

    [ https://issues.apache.org/jira/browse/HDFS-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209291#comment-16209291 ] 

Weiwei Yang edited comment on HDFS-11468 at 10/18/17 1:06 PM:
--------------------------------------------------------------

Hi [~linyiqun]

bq. Since metric is the data of aggregated statistics. I'd like to update this as ConainerSize. This will look simplify and also good understanding.

First time I read this metric name, I don't know what exact it is, that was why I suggested to use a long name. After all we have a lot of long names already as metric names. E.g {{LoadingFsImageCount}}, {{LoadingFsImageElapsedTime}}, and that explains what they are better (not every one looks the docs).

bq. There will be some more type scm metrics added into SCMMetrics in the future. Why we merge these metrics into that class? SCMMXBean is just the JMX interface for exposing scm information.

These are SCM level metrics right? Is it a bit overlapping with SCMMXBean?

Overall I am +0.5 to the patch, just want to get upon parts clear before getting this in. Hope that makes sense thanks.


was (Author: cheersyang):
Hi [~linyiqun]

bq. Since metric is the data of aggregated statistics. I'd like to update this as ConainerSize. This will look simplify and also good understanding.

First time I read this metric name, I don't know what exact it is, that was why I suggested to use a long name. After all we have a lot of long names already as metric names. E.g {{LoadingFsImageCount}}, {{LoadingFsImageElapsedTime}}, and that explains what they are better (not every one looks the docs).

bq. There will be some more type scm metrics added into SCMMetrics in the future. Why we merge these metrics into that class? SCMMXBean is just the JMX interface for exposing scm information.

These are SCM level metrics right? Is it a bit overlapping with SCMMXBean?

Overall I am +0.5 to the patch, just want to upon parts clear before getting this in. Hope that makes sense thanks.

> Ozone: SCM: Add Node Metrics for SCM
> ------------------------------------
>
>                 Key: HDFS-11468
>                 URL: https://issues.apache.org/jira/browse/HDFS-11468
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Xiaoyu Yao
>            Assignee: Yiqun Lin
>            Priority: Critical
>              Labels: OzonePostMerge
>         Attachments: HDFS-11468-HDFS-7240.001.patch, HDFS-11468-HDFS-7240.002.patch, HDFS-11468-HDFS-7240.003.patch
>
>
> This ticket is opened to add node metrics in SCM based on heartbeat, node report and container report from datanodes. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org