You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by satishd <gi...@git.apache.org> on 2016/02/04 06:42:12 UTC
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
GitHub user satishd opened a pull request:
https://github.com/apache/storm/pull/1076
STORM-1522 should create error worker log location only when error-host and error-port are available
STORM-1522 should create error worker log location only when error-host and error-port are available
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/satishd/storm STORM-1522
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1076
----
commit e7c415f5d6833bc45c01eef4363bd953e158c96f
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-02-04T05:41:03Z
STORM-1522 should create error worker log location only when error-host and error-port are available
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-185095359
@harshach Raised https://github.com/apache/storm/pull/1116 on 1.x branch .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-182589360
Sounds good +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-179942647
The code looks OK to me, but I am a little confused about when would we get an invalid host or port for the error? The only time I can see is when we are doing a rolling upgrade and there are really old errors still in ZooKeeper. Or you have not upgraded all of the hosts, but have upgraded nimbus + the UI.
I am +1 for the change, but I still would like to understand it a bit better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-180188920
when REST API (http://localhost:8080/api/v1/topology/{topology-name}) is used for getting topology details. It throws up spouts/bolts details like below which has wrong 'errorWrokerLogLink'.
errorWorkerLogLink values are created with the error info available. But the current code is generating an error link even though it does not have host/port info which comes from errors. When there are no errors, host/port values are empty and generating an invalid link.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-180259693
+1
It doesn't affect UI (since no error occurs) but API still shows broken link, which let us feel odd.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-185018994
@satishd can you open this up against 1.x-branch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1522 should create error worker log loca...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1076#issuecomment-186386735
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---