You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by dlukyanov <gi...@git.apache.org> on 2017/04/26 08:26:00 UTC

[GitHub] zeppelin pull request #2287: SSL Support for Groovy Interpreter HTTP request...

GitHub user dlukyanov opened a pull request:

    https://github.com/apache/zeppelin/pull/2287

    SSL Support for Groovy Interpreter HTTP requests [ZEPPELIN-2443]

    ### What is this PR for?
    
    Target: Create ability to call http services with custom keystores in a groovy way.
    The following should work:
    ```
    //connect to host xxx.yyy with special keystore
    HTTP.get(
      url: "https://xxx.yyy/zzz",
      ssl: " HTTP.getKeystoreSSLContext('./xxx_yyy_keystore.jks', 'testpass') "
    )
    //take context initialization code from groovy interpreter properties
    HTTP.get(
      url: "https://xxx.yyy/zzz",
      ssl: g.SSL_CONTEXT_FROM_GROOVY_INTERPRET_PROPERTIES
    )
    //connect to host xxx.yyy with trust all (do not check trust certificates - dev mode only) 
    HTTP.get(
      url: "https://xxx.yyy/zzz",
      ssl: " HTTP.getNaiveSSLContext() "
    )
    //
    HTTP.get(
      url: "https://xxx.yyy/zzz",
      ssl: " MyCustomSSLBuilder.build() "
    )
    ```
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    [ZEPPELIN-2443]
    
    ### How should this be tested?
    follow the samples above or in documentation
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? NO
    * Does this needs documentation? YES


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlukyanov/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2287
    
----
commit 4baa22e2b4db99e7b55c42a2ee5163b9b27ca5e8
Author: dlukyanov <dl...@ukr.net>
Date:   2017-04-26T06:38:05Z

    ZEPPELIN-2443

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2287: SSL Support for Groovy Interpreter HTTP request...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2287


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2287: SSL Support for Groovy Interpreter HTTP requests [ZEPP...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2287
  
    CI build https://travis-ci.org/dlukyanov/zeppelin/builds/225949679
    
    LGTM and merge to master if no further discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---