You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Ankit Kailaswar <an...@gmail.com> on 2018/05/18 11:22:30 UTC
Review Request 67214: git diff origin/master master >> Lens-150
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java b703e132
lens-client/src/main/java/org/apache/lens/client/LensConnection.java bb15b23c
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java f14ae44a
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/1/
Testing
-------
build logs :
INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
[INFO] Lens ............................................... SUCCESS [ 4.058 s]
[INFO] Lens API ........................................... SUCCESS [ 12.199 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
[INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
[INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
[INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
[INFO] Lens client ........................................ SUCCESS [ 10.876 s]
[INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
[INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:02 min
[INFO] Finished at: 2018-05-18T16:49:55+05:30
[INFO] Final Memory: 169M/1676M
[INFO] ------------------------------------------------------------------------
IM2086-X3:lens ankit.kailaswar$
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Ankit Kailaswar <an...@gmail.com>.
> On May 18, 2018, 12:58 p.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServer.java
> > Lines 286 (patched)
> > <https://reviews.apache.org/r/67214/diff/1/?file=2025351#file2025351line289>
> >
> > Is it ok if this is null?
null should be allowed here. We should reply on Grizzly server creation flow to throw specific Exception or Runtim Exception instead.
> On May 18, 2018, 12:58 p.m., Rajitha R wrote:
> > lens-server/src/test/resources/lens-site.xml
> > Lines 230 (patched)
> > <https://reviews.apache.org/r/67214/diff/1/?file=2025353#file2025353line230>
> >
> > This might have to be set to something under /tmp like other configs
Generally this has to be in install directory with specific privileges. Its better to have above mentioned path as default path for certs.
- Ankit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203407
-----------------------------------------------------------
On May 18, 2018, 11:22 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 11:22 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java b703e132
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bb15b23c
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java f14ae44a
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/1/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203407
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java
Lines 10 (patched)
<https://reviews.apache.org/r/67214/#comment285612>
this needs to be removed, license to be added
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java
Lines 13 (patched)
<https://reviews.apache.org/r/67214/#comment285616>
Can you add more details about the purpose of this class in comments?
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 1 (patched)
<https://reviews.apache.org/r/67214/#comment285610>
Missing license?
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 13 (patched)
<https://reviews.apache.org/r/67214/#comment285609>
remove this
lens-server/src/main/java/org/apache/lens/server/LensServer.java
Lines 286 (patched)
<https://reviews.apache.org/r/67214/#comment285608>
Is it ok if this is null?
lens-server/src/test/resources/lens-site.xml
Lines 230 (patched)
<https://reviews.apache.org/r/67214/#comment285607>
This might have to be set to something under /tmp like other configs
- Rajitha R
On May 18, 2018, 11:22 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 11:22 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java b703e132
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java bb15b23c
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java f14ae44a
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/1/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: enable SSL/TLS for lens server and client
communication
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203781
-----------------------------------------------------------
Ship it!
Ship It!
- Rajitha R
On May 24, 2018, 2:59 p.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 24, 2018, 2:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java b81d0a83
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/java/org/apache/lens/server/auth/DelegationTokenAuthenticationFilter.java 2650bc74
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/5/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] --- maven-install-plugin:2.5.2:install (default-install) @ lens-python-client ---
> [INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.592 s]
> [INFO] Lens ............................................... SUCCESS [ 3.158 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.665 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 12.859 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 21.058 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 5.129 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.823 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.549 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.146 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 8.624 s]
> [INFO] Lens Server ........................................ SUCCESS [ 35.410 s]
> [INFO] Lens client ........................................ SUCCESS [ 9.940 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 9.872 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 5.722 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.786 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 14.584 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 12.489 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.265 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.675 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.392 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.211 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.209 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.210 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:12 min
> [INFO] Finished at: 2018-05-24T19:22:20+05:30
> [INFO] Final Memory: 172M/1716M
> [INFO] ------------------------------------------------------------------------
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: enable SSL/TLS for lens server and client
communication
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
(Updated May 24, 2018, 2:59 p.m.)
Review request for lens.
Bugs: LENS-1511
https://issues.apache.org/jira/browse/LENS-1511
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java b81d0a83
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/java/org/apache/lens/server/auth/DelegationTokenAuthenticationFilter.java 2650bc74
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/5/
Changes: https://reviews.apache.org/r/67214/diff/4-5/
Testing
-------
build logs :
INFO] --- maven-install-plugin:2.5.2:install (default-install) @ lens-python-client ---
[INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.592 s]
[INFO] Lens ............................................... SUCCESS [ 3.158 s]
[INFO] Lens API ........................................... SUCCESS [ 12.665 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.859 s]
[INFO] Lens Cube .......................................... SUCCESS [ 21.058 s]
[INFO] Lens DB storage .................................... SUCCESS [ 5.129 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.823 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.549 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.146 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 8.624 s]
[INFO] Lens Server ........................................ SUCCESS [ 35.410 s]
[INFO] Lens client ........................................ SUCCESS [ 9.940 s]
[INFO] Lens CLI ........................................... SUCCESS [ 9.872 s]
[INFO] Lens Examples ...................................... SUCCESS [ 5.722 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.786 s]
[INFO] Lens Distribution .................................. SUCCESS [ 14.584 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 12.489 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.265 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.675 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.392 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.211 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.209 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.210 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:12 min
[INFO] Finished at: 2018-05-24T19:22:20+05:30
[INFO] Final Memory: 172M/1716M
[INFO] ------------------------------------------------------------------------
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar
Re: Review Request 67214: enable SSL/TLS for lens server and client
communication
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
(Updated May 24, 2018, 2:46 p.m.)
Review request for lens.
Bugs: LENS-1511
https://issues.apache.org/jira/browse/LENS-1511
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs (updated)
-----
contrib/clients/python/lens/client/log.py e427f7fb
contrib/clients/python/lens/client/main.py 9eae6fce
contrib/clients/python/lens/client/query.py b09ff19d
contrib/clients/python/lens/client/session.py 3b527e01
lens-api/src/main/java/org/apache/lens/api/auth/AuthHeader.java ae017d6d
lens-client/src/main/java/org/apache/lens/client/DelegationTokenClientFilter.java 0a11bf6a
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
lens-client/src/main/java/org/apache/lens/client/LensConnectionParams.java 01ae4dc4
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java b81d0a83
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/java/org/apache/lens/server/auth/DelegationTokenAuthenticationFilter.java 2650bc74
lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java 24773818
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/4/
Changes: https://reviews.apache.org/r/67214/diff/3-4/
Testing
-------
build logs :
INFO] --- maven-install-plugin:2.5.2:install (default-install) @ lens-python-client ---
[INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.592 s]
[INFO] Lens ............................................... SUCCESS [ 3.158 s]
[INFO] Lens API ........................................... SUCCESS [ 12.665 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.859 s]
[INFO] Lens Cube .......................................... SUCCESS [ 21.058 s]
[INFO] Lens DB storage .................................... SUCCESS [ 5.129 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.823 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.549 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.146 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 8.624 s]
[INFO] Lens Server ........................................ SUCCESS [ 35.410 s]
[INFO] Lens client ........................................ SUCCESS [ 9.940 s]
[INFO] Lens CLI ........................................... SUCCESS [ 9.872 s]
[INFO] Lens Examples ...................................... SUCCESS [ 5.722 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.786 s]
[INFO] Lens Distribution .................................. SUCCESS [ 14.584 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 12.489 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.265 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.675 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.392 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.211 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.209 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.210 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:12 min
[INFO] Finished at: 2018-05-24T19:22:20+05:30
[INFO] Final Memory: 172M/1716M
[INFO] ------------------------------------------------------------------------
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar
Re: Review Request 67214: enable SSL/TLS for lens server and client
communication
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
(Updated May 24, 2018, 1:53 p.m.)
Review request for lens.
Summary (updated)
-----------------
enable SSL/TLS for lens server and client communication
Bugs: LENS-1511
https://issues.apache.org/jira/browse/LENS-1511
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/3/
Testing (updated)
-------
build logs :
INFO] --- maven-install-plugin:2.5.2:install (default-install) @ lens-python-client ---
[INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.592 s]
[INFO] Lens ............................................... SUCCESS [ 3.158 s]
[INFO] Lens API ........................................... SUCCESS [ 12.665 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 12.859 s]
[INFO] Lens Cube .......................................... SUCCESS [ 21.058 s]
[INFO] Lens DB storage .................................... SUCCESS [ 5.129 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.823 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.549 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.146 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 8.624 s]
[INFO] Lens Server ........................................ SUCCESS [ 35.410 s]
[INFO] Lens client ........................................ SUCCESS [ 9.940 s]
[INFO] Lens CLI ........................................... SUCCESS [ 9.872 s]
[INFO] Lens Examples ...................................... SUCCESS [ 5.722 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.786 s]
[INFO] Lens Distribution .................................. SUCCESS [ 14.584 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 12.489 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.265 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.675 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.392 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.211 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.209 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.210 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:12 min
[INFO] Finished at: 2018-05-24T19:22:20+05:30
[INFO] Final Memory: 172M/1716M
[INFO] ------------------------------------------------------------------------
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
(Updated May 24, 2018, 1:15 p.m.)
Review request for lens.
Bugs: LENS-1511
https://issues.apache.org/jira/browse/LENS-1511
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/3/
Changes: https://reviews.apache.org/r/67214/diff/2-3/
Testing
-------
build logs :
INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
[INFO] Lens ............................................... SUCCESS [ 4.058 s]
[INFO] Lens API ........................................... SUCCESS [ 12.199 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
[INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
[INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
[INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
[INFO] Lens client ........................................ SUCCESS [ 10.876 s]
[INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
[INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:02 min
[INFO] Finished at: 2018-05-18T16:49:55+05:30
[INFO] Final Memory: 169M/1676M
[INFO] ------------------------------------------------------------------------
IM2086-X3:lens ankit.kailaswar$
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Ankit Kailaswar <an...@gmail.com>.
> On May 21, 2018, 6:42 a.m., Rajitha R wrote:
> > lens-server/src/main/java/org/apache/lens/server/LensServer.java
> > Lines 296 (patched)
> > <https://reviews.apache.org/r/67214/diff/2/?file=2026212#file2026212line299>
> >
> > "null should be allowed here. We should reply on Grizzly server creation flow to throw specific Exception or Runtim Exception instead.
> > "
> > This reply is unclear..if the password is not set, are we throwing an exception here ? since I can't see any. Am I missing something?
As discuused offline SSLContextConfigurator should handle password instead of we explicitly doing it.
- Ankit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203481
-----------------------------------------------------------
On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 4:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/2/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203481
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Line 15 (original)
<https://reviews.apache.org/r/67214/#comment285733>
Description missing for this class as well
lens-server/src/main/java/org/apache/lens/server/LensServer.java
Lines 296 (patched)
<https://reviews.apache.org/r/67214/#comment285735>
"null should be allowed here. We should reply on Grizzly server creation flow to throw specific Exception or Runtim Exception instead.
"
This reply is unclear..if the password is not set, are we throwing an exception here ? since I can't see any. Am I missing something?
lens-server/src/main/resources/lensserver-default.xml
Lines 989 (patched)
<https://reviews.apache.org/r/67214/#comment285734>
this has to still be /tmp which is the default install dir. /usr/local is very specific to Inmobi.
- Rajitha R
On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 4:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/2/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Ankit Kailaswar <an...@gmail.com>.
> On May 21, 2018, 7:35 a.m., Puneet Gupta wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/67214/diff/2/?file=2026209#file2026209line63>
> >
> > Should we have separate config for client and server to ignore certificate check ?
We are providing functionality of one way trust only, client will be verifying server's cert and vice versa is not true. We can have this feature in future with seperate config flag for server and client.
> On May 21, 2018, 7:35 a.m., Puneet Gupta wrote:
> > lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/67214/diff/2/?file=2026209#file2026209line87>
> >
> > Should this not come from trustManager.getAcceptedIssuers() ?
yes, updated the same.
> On May 21, 2018, 7:35 a.m., Puneet Gupta wrote:
> > lens-server/src/main/resources/lensserver-default.xml
> > Lines 984 (patched)
> > <https://reviews.apache.org/r/67214/diff/2/?file=2026213#file2026213line984>
> >
> > incomplete description. Please update
updated
- Ankit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203483
-----------------------------------------------------------
On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 4:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/2/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/#review203483
-----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 63 (patched)
<https://reviews.apache.org/r/67214/#comment285736>
Should we have separate config for client and server to ignore certificate check ?
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java
Lines 87 (patched)
<https://reviews.apache.org/r/67214/#comment285737>
Should this not come from trustManager.getAcceptedIssuers() ?
lens-server/src/main/resources/lensserver-default.xml
Lines 984 (patched)
<https://reviews.apache.org/r/67214/#comment285738>
incomplete description. Please update
- Puneet Gupta
On May 21, 2018, 4:46 a.m., Ankit Kailaswar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67214/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 4:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1511
> https://issues.apache.org/jira/browse/LENS-1511
>
>
> Repository: lens
>
>
> Description
> -------
>
> enable SSL/TLS for lens server and client communication
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
> lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
> lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
> lens-client/src/main/resources/lens-client-default.xml 132e1b14
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
> lens-server/src/main/resources/lensserver-default.xml bef82518
> lens-server/src/test/resources/lens-site.xml f5a02376
> src/site/apt/admin/config.apt 8720c822
> src/site/apt/admin/hivedriver-config.apt 221c1662
> src/site/apt/user/olap-query-conf.apt 90d635b8
>
>
> Diff: https://reviews.apache.org/r/67214/diff/2/
>
>
> Testing
> -------
>
> build logs :
>
> INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
> [INFO] Lens ............................................... SUCCESS [ 4.058 s]
> [INFO] Lens API ........................................... SUCCESS [ 12.199 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
> [INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
> [INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
> [INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
> [INFO] Lens client ........................................ SUCCESS [ 10.876 s]
> [INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
> [INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
> [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
> [INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
> [INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
> [INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
> [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
> [INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 03:02 min
> [INFO] Finished at: 2018-05-18T16:49:55+05:30
> [INFO] Final Memory: 169M/1676M
> [INFO] ------------------------------------------------------------------------
> IM2086-X3:lens ankit.kailaswar$
>
>
> Tested with Firefox, curl, python client, lens-client.
>
> lens client logs,
>
> 18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
> 18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
> 18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
>
>
> Thanks,
>
> Ankit Kailaswar
>
>
Re: Review Request 67214: git diff origin/master master >> Lens-150
Posted by Ankit Kailaswar <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67214/
-----------------------------------------------------------
(Updated May 21, 2018, 4:46 a.m.)
Review request for lens.
Bugs: LENS-1511
https://issues.apache.org/jira/browse/LENS-1511
Repository: lens
Description
-------
enable SSL/TLS for lens server and client communication
Diffs (updated)
-----
lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java eb12ee30
lens-client/src/main/java/org/apache/lens/client/LensConnection.java ab498314
lens-client/src/main/java/org/apache/lens/client/LensHostnameVerifier.java PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensTrustManager.java PRE-CREATION
lens-client/src/main/resources/lens-client-default.xml 132e1b14
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bda995dd
lens-server/src/main/java/org/apache/lens/server/LensServer.java 7f8b3363
lens-server/src/main/resources/lensserver-default.xml bef82518
lens-server/src/test/resources/lens-site.xml f5a02376
src/site/apt/admin/config.apt 8720c822
src/site/apt/admin/hivedriver-config.apt 221c1662
src/site/apt/user/olap-query-conf.apt 90d635b8
Diff: https://reviews.apache.org/r/67214/diff/2/
Changes: https://reviews.apache.org/r/67214/diff/1-2/
Testing
-------
build logs :
INFO] Installing /Users/ankit.kailaswar/inmobi/apache/lens1/lens/contrib/clients/python/pom.xml to /Users/ankit.kailaswar/.m2/repository/org/apache/lens/lens-python-client/2.8.0-SNAPSHOT/lens-python-client-2.8.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.732 s]
[INFO] Lens ............................................... SUCCESS [ 4.058 s]
[INFO] Lens API ........................................... SUCCESS [ 12.199 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 11.348 s]
[INFO] Lens Cube .......................................... SUCCESS [ 20.835 s]
[INFO] Lens DB storage .................................... SUCCESS [ 4.510 s]
[INFO] Lens Query Library ................................. SUCCESS [ 6.098 s]
[INFO] Lens Hive Driver ................................... SUCCESS [ 8.414 s]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 9.297 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 7.908 s]
[INFO] Lens Server ........................................ SUCCESS [ 33.810 s]
[INFO] Lens client ........................................ SUCCESS [ 10.876 s]
[INFO] Lens CLI ........................................... SUCCESS [ 7.791 s]
[INFO] Lens Examples ...................................... SUCCESS [ 4.987 s]
[INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.771 s]
[INFO] Lens Distribution .................................. SUCCESS [ 12.208 s]
[INFO] Lens ML Lib ........................................ SUCCESS [ 11.166 s]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.854 s]
[INFO] Lens Regression .................................... SUCCESS [ 7.349 s]
[INFO] Lens UI ............................................ SUCCESS [ 2.988 s]
[INFO] Lens Contrib ....................................... SUCCESS [ 0.203 s]
[INFO] Lens Contributed Clients ........................... SUCCESS [ 0.191 s]
[INFO] Lens Python Client ................................. SUCCESS [ 0.202 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:02 min
[INFO] Finished at: 2018-05-18T16:49:55+05:30
[INFO] Final Memory: 169M/1676M
[INFO] ------------------------------------------------------------------------
IM2086-X3:lens ankit.kailaswar$
Tested with Firefox, curl, python client, lens-client.
lens client logs,
18 May 2018 09:27:22 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:27:53 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:28:30 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:03 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:05 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:30:09 [Thread-2] INFO org.apache.lens.client.LensConnection - SSL is disabled, Creating http client.
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnectionParams - Request filter added requestfilter
18 May 2018 09:33:15 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
18 May 2018 09:33:17 [Spring Shell] INFO org.apache.lens.client.LensConnection - SSL is enabled, Creating https client.
Thanks,
Ankit Kailaswar