You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:33:46 UTC

[GitHub] [flink] JingsongLi opened a new pull request #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

JingsongLi opened a new pull request #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597
 
 
   ## What is the purpose of the change
   
   After FLINK-12399. there are bugs in OrcTableSource.
   
   The case is there are some filters to be pushed down to source, but source can not consume them. We need distinguish empty filters from no pushed down in expainSource.
   
   ## Brief change log
   
   Return "null" if no filter pushed down, return "true" there is filter pushed down.
   
   ## Verifying this change
   
   `OrcTableSourceTest.testUnsupportedPredOnly`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607145878
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit cc19dad21070063117be199d82375fa2f8d25e63 (Wed Apr 01 09:38:53 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157465531",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157687198",
       "triggerID" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157687198) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157465531",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc19dad21070063117be199d82375fa2f8d25e63 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157465531) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157465531",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc19dad21070063117be199d82375fa2f8d25e63 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157465531) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157465531",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157687198",
       "triggerID" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc19dad21070063117be199d82375fa2f8d25e63 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157465531) 
   * 3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157687198) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc19dad21070063117be199d82375fa2f8d25e63 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597#issuecomment-607147948
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157465531",
       "triggerID" : "cc19dad21070063117be199d82375fa2f8d25e63",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cc19dad21070063117be199d82375fa2f8d25e63 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/157465531) 
   * 3006b8d9082abbb286fbfbdcdc2a0d4717bca5d8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi merged pull request #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #11597: [FLINK-16860][orc] Distinguish empty filters from no pushed down in expainSource
URL: https://github.com/apache/flink/pull/11597
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services