[GitHub] [iceberg] rdblue commented on a diff in pull request #2639: Parquet: Support parquet modular encryption

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1133143769


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -203,6 +210,16 @@ public WriteBuilder writerVersion(WriterVersion version) {
       return this;
     }
 
+    public WriteBuilder withFileEncryptionKey(ByteBuffer encryptionKey) {
+      this.fileEncryptionKey = encryptionKey;
+      return this;
+    }
+
+    public WriteBuilder withAadPrefix(ByteBuffer aadPrefix) {

Review Comment:
   I think this should be `withAADPrefix`. We don't follow the Java convention of lower-casing commonly uppercase acronyms.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org