You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by BryanCutler <gi...@git.apache.org> on 2018/11/20 19:00:20 UTC

[GitHub] spark pull request #21465: [SPARK-24333][ML][PYTHON]Add fit with validation ...

Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21465#discussion_r235128413
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -1176,8 +1176,8 @@ def trees(self):
     
     @inherit_doc
     class GBTClassifier(JavaEstimator, HasFeaturesCol, HasLabelCol, HasPredictionCol, HasMaxIter,
    -                    GBTParams, HasCheckpointInterval, HasStepSize, HasSeed, JavaMLWritable,
    -                    JavaMLReadable):
    +                    GBTParams, HasCheckpointInterval, HasStepSize, HasSeed,
    +                    HasValidationIndicatorCol, JavaMLWritable, JavaMLReadable):
    --- End diff --
    
    I think this should be added to `GBTParams`, which is done on the Scala side too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org