[GitHub] [druid] imply-cheddar commented on a diff in pull request #14002: lower segment heap footprint and fix bug with expression type coercion

["imply-cheddar (via GitHub)" <gi...@apache.org>]

imply-cheddar commented on code in PR #14002:
URL: https://github.com/apache/druid/pull/14002#discussion_r1154121916


##########
processing/src/main/java/org/apache/druid/java/util/common/io/smoosh/SmooshedFileMapper.java:
##########
@@ -48,7 +48,11 @@
  */
 public class SmooshedFileMapper implements Closeable
 {
-  private static final Interner<String> STRING_INTERNER = Interners.newWeakInterner();
+  /**
+   * Interner for smoosh internal files, which includes all column names since very column has an internal file

Review Comment:
   typo: s/very/every/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org