You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mas-chen (via GitHub)" <gi...@apache.org> on 2023/04/27 00:12:04 UTC
[GitHub] [flink-connector-kafka] mas-chen opened a new pull request, #25: [FLINK-30859] Sync flink sql client test
mas-chen opened a new pull request, #25:
URL: https://github.com/apache/flink-connector-kafka/pull/25
final code to move, before Kafka code can be deleted from master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mas-chen commented on pull request #25: [FLINK-30859] Sync flink sql client test
Posted by "mas-chen (via GitHub)" <gi...@apache.org>.
mas-chen commented on PR #25:
URL: https://github.com/apache/flink-connector-kafka/pull/25#issuecomment-1593889106
Discussed offline to allow pinning versions with test scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on pull request #25: [FLINK-30859] Sync flink sql client test
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on PR #25:
URL: https://github.com/apache/flink-connector-kafka/pull/25#issuecomment-1563139310
On a second look, it looks like this test does far more stuff than just testing the SQL Kafka Connector ...
Again, like the state machine example PR, I'm not sure we really should be moving the whole e2e test as is, but rather:
1. modify the original E2E in `apache/flink` to not use Kafka
2. Move over only the parts related to Kafka in `apache/flink-connector-kafka`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #25: [FLINK-30859] Sync flink sql client test
Posted by "tzulitai (via GitHub)" <gi...@apache.org>.
tzulitai commented on code in PR #25:
URL: https://github.com/apache/flink-connector-kafka/pull/25#discussion_r1205621149
##########
flink-connector-kafka-e2e-tests/flink-sql-client-test/pom.xml:
##########
@@ -0,0 +1,129 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-kafka-e2e-tests</artifactId>
+ <version>3.1-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>flink-sql-client-test</artifactId>
+ <name>Flink : E2E Tests : SQL client</name>
+ <packaging>jar</packaging>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-end-to-end-tests-common-kafka</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <!-- The following dependencies are for connector/format sql-jars that
+ we copy using the maven-dependency-plugin. When extending the test
+ to cover more connectors/formats, add a dependency here and an entry
+ to the dependency-plugin configuration below.
+ This ensures that all modules we actually need (as defined by the
+ dependency-plugin configuration) are built before this module. -->
Review Comment:
Is this comment still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-kafka] mas-chen closed pull request #25: [FLINK-30859] Sync flink sql client test
Posted by "mas-chen (via GitHub)" <gi...@apache.org>.
mas-chen closed pull request #25: [FLINK-30859] Sync flink sql client test
URL: https://github.com/apache/flink-connector-kafka/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org