[GitHub] [beam] robertwb commented on a change in pull request #12259: [BEAM-9561] Run Pandas tests on Beam.

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #12259:
URL: https://github.com/apache/beam/pull/12259#discussion_r456143684



##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -240,13 +256,31 @@ class BeamDataframeDoctestRunner(doctest.DocTestRunner):
   """A Doctest runner suitable for replacing the `pd` module with one backed
   by beam.
   """
-  def __init__(self, env, use_beam=True, **kwargs):
+  def __init__(self, env, use_beam=True, skip=None, **kwargs):
     self._test_env = env
+
+    def to_callable(cond):
+      if cond == '*':

Review comment:
       I started out supporting regex, but realized it'd be painful to have to escape things like parentheses, brackets, dots, etc. in code snippets. (This is internal, so we could always add this later. Some ideas I've had would be to special case `"/regex-here/"` or pass through callables to allow `re.compile("regex").match`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org