[GitHub] [incubator-netbeans] junichi11 edited a comment on issue #1199: [NETBEANS-1696] PHP 7.4 Support

[GitBox <gi...@apache.org>]

junichi11 edited a comment on issue #1199: [NETBEANS-1696] PHP 7.4 Support
URL: https://github.com/apache/incubator-netbeans/pull/1199#issuecomment-485050706
 
 
   I've investigated a bit. It seems that unit tests fail after this commit: https://github.com/apache/incubator-netbeans/commit/3357fa5b18590908ac9de4ad7e55ab1fdf88cd50
   
   Unit tests passed when I've checkout https://github.com/apache/incubator-netbeans/commit/123f616488cbd335d63da493bb19b1aaabd0ac2f (previous commit)
   e.g. 
   - https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/actions/ImportDataCreatorTest.java
   - https://github.com/apache/incubator-netbeans/blob/master/php/php.editor/test/unit/src/org/netbeans/modules/php/editor/indent/PHPFormatterHtmlTest.java
   
   #### Note
   Unit tests fail even if I install the Oracle JS Parser.
   
   @sdedic 
   Do you have any ideas to fix this problem?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists