You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/27 04:52:01 UTC

Review Request: Fixed os::memory() and fs::available() to return Bytes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10813/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

See summary


Diffs
-----

  third_party/libprocess/third_party/stout/include/stout/bytes.hpp 6a068f091b53c40af2137814726134ca7ddd168c 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
  third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819 

Diff: https://reviews.apache.org/r/10813/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fixed os::memory() and fs::available() to return Bytes.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10813/#review19821
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 27, 2013, 2:52 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10813/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 2:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/third_party/stout/include/stout/bytes.hpp 6a068f091b53c40af2137814726134ca7ddd168c 
>   third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
>   third_party/libprocess/third_party/stout/include/stout/os.hpp 4d51693504f15236c131600737d0b6ddb6a1a819 
> 
> Diff: https://reviews.apache.org/r/10813/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fixed os::memory() and fs::available() to return Bytes.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10813/
-----------------------------------------------------------

(Updated April 30, 2013, 6:11 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

rebaed. nnfr.


Description
-------

See summary


Diffs (updated)
-----

  third_party/libprocess/third_party/stout/include/stout/bytes.hpp 6a068f091b53c40af2137814726134ca7ddd168c 
  third_party/libprocess/third_party/stout/include/stout/fs.hpp ef9fb18173a592a288703b4a123da5c92a80a3e0 
  third_party/libprocess/third_party/stout/include/stout/os.hpp c71ae9ed32af2a14dc7b9b34521cb5ea6025235c 

Diff: https://reviews.apache.org/r/10813/diff/


Testing
-------

make check


Thanks,

Vinod Kone