You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/02/07 12:28:13 UTC

[GitHub] [shardingsphere] FlyingZC opened a new pull request, #24048: Rename transaction-read-query-strategy properties name(#23974)

FlyingZC opened a new pull request, #24048:
URL: https://github.com/apache/shardingsphere/pull/24048

   Fixes #23974.
   
   Changes proposed in this pull request:
     - Rename transaction-read-query-strategy properties name
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #24048: Rename transaction-read-query-strategy properties name(#23974)

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #24048:
URL: https://github.com/apache/shardingsphere/pull/24048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24048: Rename transaction-read-query-strategy properties name(#23974)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24048:
URL: https://github.com/apache/shardingsphere/pull/24048#issuecomment-1420730026

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24048](https://codecov.io/gh/apache/shardingsphere/pull/24048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7167c5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/db0b6f356d8cbff80ec8cd37165c14d471397e77?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (db0b6f3) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head e7167c5 differs from pull request most recent head 60952f3. Consider uploading reports for the commit 60952f3 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #24048   +/-   ##
   =========================================
     Coverage     50.07%   50.08%           
     Complexity     1564     1564           
   =========================================
     Files          3245     3245           
     Lines         53221    53221           
     Branches       9800     9800           
   =========================================
   + Hits          26653    26655    +2     
   + Misses        24225    24224    -1     
   + Partials       2343     2342    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../transaction/TransactionReadQueryStrategyUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/24048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvcmVhZHdyaXRlLXNwbGl0dGluZy9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGVzcGxpdHRpbmcvdHJhbnNhY3Rpb24vVHJhbnNhY3Rpb25SZWFkUXVlcnlTdHJhdGVneVV0aWwuamF2YQ==) | `85.71% <ø> (ø)` | |
   | [...authentication/OpenGaussAuthenticationHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvZnJvbnRlbmQvb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9mcm9udGVuZC9vcGVuZ2F1c3MvYXV0aGVudGljYXRpb24vT3BlbkdhdXNzQXV0aGVudGljYXRpb25IYW5kbGVyLmphdmE=) | `86.36% <0.00%> (+4.54%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org