You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/12/21 21:51:55 UTC
Review Request 54948: fix unsafe concurrent mods on expiredTombstones
ArrayList
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54948/
-----------------------------------------------------------
Review request for geode and anilkumar gingade.
Bugs: GEODE-2240
https://issues.apache.org/jira/browse/GEODE-2240
Repository: geode
Description
-------
when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java 2840134a5466a6bd4552ead334645889d761ce88
Diff: https://reviews.apache.org/r/54948/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 54948: fix unsafe concurrent mods on
expiredTombstones ArrayList
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54948/#review161147
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Jan. 9, 2017, 11:47 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54948/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 11:47 p.m.)
>
>
> Review request for geode and anilkumar gingade.
>
>
> Bugs: GEODE-2240
> https://issues.apache.org/jira/browse/GEODE-2240
>
>
> Repository: geode
>
>
> Description
> -------
>
> when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java 2840134a5466a6bd4552ead334645889d761ce88
>
> Diff: https://reviews.apache.org/r/54948/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 54948: fix unsafe concurrent mods on
expiredTombstones ArrayList
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54948/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 3:47 p.m.)
Review request for geode and anilkumar gingade.
Changes
-------
The previous fix caused a deadlock because of lock inversion on the queueHeadLock and the blockGCLock.
This fix introduces a new lock used when modifying or iterating the expiredTombstones.
Tests that failed with the previous deadlock are now passing.
Bugs: GEODE-2240
https://issues.apache.org/jira/browse/GEODE-2240
Repository: geode
Description
-------
when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock.
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java 2840134a5466a6bd4552ead334645889d761ce88
Diff: https://reviews.apache.org/r/54948/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 54948: fix unsafe concurrent mods on
expiredTombstones ArrayList
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54948/#review160009
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On Dec. 21, 2016, 9:51 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54948/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 9:51 p.m.)
>
>
> Review request for geode and anilkumar gingade.
>
>
> Bugs: GEODE-2240
> https://issues.apache.org/jira/browse/GEODE-2240
>
>
> Repository: geode
>
>
> Description
> -------
>
> when adding to the expiredTombstones ArrayList the code now holds a sync on getBlockGCLock.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java 2840134a5466a6bd4552ead334645889d761ce88
>
> Diff: https://reviews.apache.org/r/54948/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>