You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/05/04 17:00:03 UTC
[jira] [Created] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
--------------------------------------------------------------------------------------------------
Key: WHIRR-297
URL: https://issues.apache.org/jira/browse/WHIRR-297
Project: Whirr
Issue Type: Sub-task
Components: service/elasticsearch, service/zookeeper
Reporter: Andrei Savu
Assignee: Andrei Savu
Fix For: 0.5.0
Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
We should have something like:
{start,stop,install,configure,cleanup}_zookeeper
{start,stop,install,configure,cleanup}_elasticsearch
Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-297:
------------------------------
Attachment: WHIRR-297.patch
Resubmitting the patch to this sub-task so that we can commit and close if it looks ok. Integration tests pass on EC2.
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
> Key: WHIRR-297
> URL: https://issues.apache.org/jira/browse/WHIRR-297
> Project: Whirr
> Issue Type: Sub-task
> Components: service/elasticsearch, service/zookeeper
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like:
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-297:
------------------------------
Status: Patch Available (was: Open)
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
> Key: WHIRR-297
> URL: https://issues.apache.org/jira/browse/WHIRR-297
> Project: Whirr
> Issue Type: Sub-task
> Components: service/elasticsearch, service/zookeeper
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like:
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-297:
------------------------------
Attachment: WHIRR-297.patch
Removed code from ScriptBasedClusterAction. I'm going to commit this. We can do more refactoring in new patches.
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
> Key: WHIRR-297
> URL: https://issues.apache.org/jira/browse/WHIRR-297
> Project: Whirr
> Issue Type: Sub-task
> Components: service/elasticsearch, service/zookeeper
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-297.patch, WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like:
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029122#comment-13029122 ]
Tom White commented on WHIRR-297:
---------------------------------
+1 Looks good, with one caveat. I would rather ScriptBasedClusterAction didn't install any scripts by default, since they may not be needed by all services, and they bulk up the aggregated scripts that are transferred over SSH to each node. Also, in a Puppet or Chef world, they would be unused, I think.
Would it be reasonable to have action handlers do the registration? (I'm thinking that we could shorten the syntax so you can register more than one script in one go: e.g. {{addStatements(event, allOf("install_java", "install_service", "remove_service"));}} - this could go in a future JIRA, if needed.)
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
> Key: WHIRR-297
> URL: https://issues.apache.org/jira/browse/WHIRR-297
> Project: Whirr
> Issue Type: Sub-task
> Components: service/elasticsearch, service/zookeeper
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like:
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-297) Separate ZooKeeper and ElasticSearch
install and configuration scripts into more generic functions
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-297:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Tom for reviewing.
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions
> --------------------------------------------------------------------------------------------------
>
> Key: WHIRR-297
> URL: https://issues.apache.org/jira/browse/WHIRR-297
> Project: Whirr
> Issue Type: Sub-task
> Components: service/elasticsearch, service/zookeeper
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Fix For: 0.5.0
>
> Attachments: WHIRR-297.patch, WHIRR-297.patch
>
>
> Separate ZooKeeper and ElasticSearch install and configuration scripts into more generic functions.
> We should have something like:
> {start,stop,install,configure,cleanup}_zookeeper
> {start,stop,install,configure,cleanup}_elasticsearch
> Naming consistency would be helpful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira