You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org> on 2008/10/07 22:58:46 UTC
[jira] Created: (QPID-1326) JMS Connection URL not parsed correctly
JMS Connection URL not parsed correctly
---------------------------------------
Key: QPID-1326
URL: https://issues.apache.org/jira/browse/QPID-1326
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: M4
Reporter: Rajith Attapattu
Fix For: M4
The following connection URL is parsed incorrectly.
amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1326) JMS Connection URL not parsed correctly
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-1326:
-----------------------------------
Fix Version/s: M4
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Fix For: M4
>
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1326) JMS Connection URL not parsed
correctly
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645366#action_12645366 ]
Rajith Attapattu commented on QPID-1326:
----------------------------------------
I modified the code to throw an exception for the above case.
It's checked in r711740 on trunk.
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Fix For: M4
>
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1326) JMS Connection URL not parsed
correctly
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645373#action_12645373 ]
Martin Ritchie commented on QPID-1326:
--------------------------------------
Hi,
Rajith I thought we discussed parsing both as the transport:host:port format is more correct than the hierarchical format we currently have.
Also any chance you could add a test as this makes reviewing the change much easier.
Cheers
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
> Fix For: M4
>
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1326) JMS Connection URL not parsed
correctly
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653357#action_12653357 ]
Rajith Attapattu commented on QPID-1326:
----------------------------------------
Martin,
Sorry I missed your comment. Please accept my appologies.
I thought we agreed on either fixing it properly or throwing an error.
I took the easy route of throwing an error.
Trying to do a proper fix was a bit tricky and we were close to a release. So I took the less risky and easy option.
Our connection URL format is very confusing.
tcp://localhost:1000, tcp:localhost:1000, localhost:1000 all seem to be valid URLs.
When we allow this sort of thing, it introduces unnessacery complications in the code and also creates confusion.
Why do we have to accomadate people who are too lazy to type up the proper URL format? That is something I never understood.
I think we have made this issue more complicated than it needs to be.
IMHO I think we need to have a look at the Connection URL code and the format after the release.
Maybe we should have sticked to the format defined by the AMQP spec group, but I believe that it is not easy bcos we need backwards compatibility to accomadate the old URL format.
I suggest we close this particular JIRA for M4 and then open up another JIRA that will spell out a more comprehensive plan for tackling this URL problem, once and for all.
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1326) JMS Connection URL not parsed
correctly
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack resolved QPID-1326.
------------------------------------
Resolution: Fixed
Resolving as per Rajith's comments
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1326) JMS Connection URL not parsed correctly
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-1326:
-----------------------------------
Fix Version/s: (was: M4)
> JMS Connection URL not parsed correctly
> ---------------------------------------
>
> Key: QPID-1326
> URL: https://issues.apache.org/jira/browse/QPID-1326
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M4
> Reporter: Rajith Attapattu
>
> The following connection URL is parsed incorrectly.
> amqp://guest:guest@/test?brokerlist='tcp:myhost:10000'
> It should either throw an error to indicate the missing "//" or it should extract the host and port correctly.
> Currently for the above URL, the host is set to "" (which defaults to localhost) and port to 5672.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.