You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Stephan Seitz <s....@secretresearchfacility.com> on 2015/12/14 16:36:33 UTC

Consoleproxy FF Quicksearch

Hi devs!

Despite the fact I was too lazy that weekend cloning the repo and filing
a pull request, I hope that small fix could make it upstream anyway.

--- ajaxviewer.js.orig 2015-12-13 11:10:47.851177577 +0000
+++ ajaxviewer.js 2015-12-13 14:14:32.367382547 +0000
@@ -649,6 +649,7 @@
this.sendingEventInProgress = false;
ajaxViewer.installMouseHook();
ajaxViewer.installKeyboardHook();
+ ajaxViewer.panel.parent().focus();

$(window).bind("resize", function() {
ajaxViewer.onWindowResize();
@@ -1259,6 +1260,7 @@
case 38 : // UP
case 39 : // RIGHT
case 40 : // DOWN
+ case 47 : // slash (prevent quick search)
return false;
}



I've already filed this as bug
https://issues.apache.org/jira/browse/CLOUDSTACK-9164

These two lines prevent Firefox from starting quicksearch which is
really annoying.

- Stephan





Re: Consoleproxy FF Quicksearch

Posted by Stephan Seitz <s....@secretresearchfacility.com>.
As a quick fix, you could modify the systemvm.iso which is used to
initialize the console-proxy-vm.

Im not sure if it's 
/usr/share/cloudstack-common/vms/systemvm.iso
or
/usr/share/cloudstack-management/webapps/client/WEB-
INF/classes/vms/systemvm.iso

Inside the systemvm.iso you'll find a systemvm.zip which contains
js/ajaxviewer.js

Here's the patch https://issues.apache.org/jira/browse/CLOUDSTACK-9164

I think it's 10 minutes worth to modify the zip content and create a
new iso.

If you're not attempting to destroy your console-proxy-vm you could
also modify /usr/local/cloud/....forgot-the-exact-path.../ajaxviewer.js 
inside the running instance.

Oh, and flushing the browsercache is also necessery.

cheers,

- Stephan



Am Montag, den 14.12.2015, 20:55 -0500 schrieb Pierre-Luc Dion:
> Yet that is very annoying, no chance it could make it in 4.7.0rc2 ?
> ...
> 
> Thanks Stephan!
> 
> 
> On Mon, Dec 14, 2015 at 10:39 AM, Nux! <nu...@li.nux.ro> wrote:
> 
> > 
> > Stephan,
> > 
> > Thanks for this. It was driving me nuts, I even complained to
> > Mozilla lol.
> > 
> > I ended up installing an extension that disabled the quicksearch on
> > "/"
> > press.
> > https://freeshell.de//~kaosmos/index-en.html#searchkeys
> > 
> > --
> > Sent from the Delta quadrant using Borg technology!
> > 
> > Nux!
> > www.nux.ro
> > 
> > ----- Original Message -----
> > > 
> > > From: "Stephan Seitz" <s....@secretresearchfacility.com>
> > > To: dev@cloudstack.apache.org
> > > Sent: Monday, 14 December, 2015 15:36:33
> > > Subject: Consoleproxy FF Quicksearch
> > > 
> > > Hi devs!
> > > 
> > > Despite the fact I was too lazy that weekend cloning the repo and
> > > filing
> > > a pull request, I hope that small fix could make it upstream
> > > anyway.
> > > 
> > > --- ajaxviewer.js.orig 2015-12-13 11:10:47.851177577 +0000
> > > +++ ajaxviewer.js 2015-12-13 14:14:32.367382547 +0000
> > > @@ -649,6 +649,7 @@
> > > this.sendingEventInProgress = false;
> > > ajaxViewer.installMouseHook();
> > > ajaxViewer.installKeyboardHook();
> > > + ajaxViewer.panel.parent().focus();
> > > 
> > > $(window).bind("resize", function() {
> > > ajaxViewer.onWindowResize();
> > > @@ -1259,6 +1260,7 @@
> > > case 38 : // UP
> > > case 39 : // RIGHT
> > > case 40 : // DOWN
> > > + case 47 : // slash (prevent quick search)
> > > return false;
> > > }
> > > 
> > > 
> > > 
> > > I've already filed this as bug
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-9164
> > > 
> > > These two lines prevent Firefox from starting quicksearch which
> > > is
> > > really annoying.
> > > 
> > > - Stephan

Re: Consoleproxy FF Quicksearch

Posted by Pierre-Luc Dion <pd...@apache.org>.
Yet that is very annoying, no chance it could make it in 4.7.0rc2 ? ...

Thanks Stephan!


On Mon, Dec 14, 2015 at 10:39 AM, Nux! <nu...@li.nux.ro> wrote:

> Stephan,
>
> Thanks for this. It was driving me nuts, I even complained to Mozilla lol.
>
> I ended up installing an extension that disabled the quicksearch on "/"
> press.
> https://freeshell.de//~kaosmos/index-en.html#searchkeys
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>
> ----- Original Message -----
> > From: "Stephan Seitz" <s....@secretresearchfacility.com>
> > To: dev@cloudstack.apache.org
> > Sent: Monday, 14 December, 2015 15:36:33
> > Subject: Consoleproxy FF Quicksearch
>
> > Hi devs!
> >
> > Despite the fact I was too lazy that weekend cloning the repo and filing
> > a pull request, I hope that small fix could make it upstream anyway.
> >
> > --- ajaxviewer.js.orig 2015-12-13 11:10:47.851177577 +0000
> > +++ ajaxviewer.js 2015-12-13 14:14:32.367382547 +0000
> > @@ -649,6 +649,7 @@
> > this.sendingEventInProgress = false;
> > ajaxViewer.installMouseHook();
> > ajaxViewer.installKeyboardHook();
> > + ajaxViewer.panel.parent().focus();
> >
> > $(window).bind("resize", function() {
> > ajaxViewer.onWindowResize();
> > @@ -1259,6 +1260,7 @@
> > case 38 : // UP
> > case 39 : // RIGHT
> > case 40 : // DOWN
> > + case 47 : // slash (prevent quick search)
> > return false;
> > }
> >
> >
> >
> > I've already filed this as bug
> > https://issues.apache.org/jira/browse/CLOUDSTACK-9164
> >
> > These two lines prevent Firefox from starting quicksearch which is
> > really annoying.
> >
> > - Stephan
>

Re: Consoleproxy FF Quicksearch

Posted by Nux! <nu...@li.nux.ro>.
Stephan,

Thanks for this. It was driving me nuts, I even complained to Mozilla lol.

I ended up installing an extension that disabled the quicksearch on "/" press.
https://freeshell.de//~kaosmos/index-en.html#searchkeys

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

----- Original Message -----
> From: "Stephan Seitz" <s....@secretresearchfacility.com>
> To: dev@cloudstack.apache.org
> Sent: Monday, 14 December, 2015 15:36:33
> Subject: Consoleproxy FF Quicksearch

> Hi devs!
> 
> Despite the fact I was too lazy that weekend cloning the repo and filing
> a pull request, I hope that small fix could make it upstream anyway.
> 
> --- ajaxviewer.js.orig 2015-12-13 11:10:47.851177577 +0000
> +++ ajaxviewer.js 2015-12-13 14:14:32.367382547 +0000
> @@ -649,6 +649,7 @@
> this.sendingEventInProgress = false;
> ajaxViewer.installMouseHook();
> ajaxViewer.installKeyboardHook();
> + ajaxViewer.panel.parent().focus();
> 
> $(window).bind("resize", function() {
> ajaxViewer.onWindowResize();
> @@ -1259,6 +1260,7 @@
> case 38 : // UP
> case 39 : // RIGHT
> case 40 : // DOWN
> + case 47 : // slash (prevent quick search)
> return false;
> }
> 
> 
> 
> I've already filed this as bug
> https://issues.apache.org/jira/browse/CLOUDSTACK-9164
> 
> These two lines prevent Firefox from starting quicksearch which is
> really annoying.
> 
> - Stephan