You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/14 18:17:04 UTC
[GitHub] [spark] shardulm94 opened a new pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
shardulm94 opened a new pull request #35852:
URL: https://github.com/apache/spark/pull/35852
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Retry `ClassSymbol.selfType` in case we receive a cyclic reference exception.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
`ClassSymbol.selfType` fails on certain classes like `HiveGenericUDF` due to cyclic reference. This issue is due to [bug#12190 in Scala](https://github.com/scala/bug/issues/12190) which does not handle cyclic references in Java annotations correctly. The cyclic reference in this case comes from `InterfaceAudience` annotation which [annotates itself](https://github.com/apache/hadoop/blob/db8ae4b65448c506c9234641b2c1f9b8e894dc18/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java#L45). This annotation class is present in the type hierarchy of `HiveGenericUDF`.
To workaround the issue, we can just retry the operation and it will succeed on the retry probably because the annotation is partially resolved from the previous attempt.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Added a unit test. This unit test prefers to be run a separate JVM as the error for cyclic references may not be thrown if the annotation class is previously loaded by some other test and so may be dependent on test execution order.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a change in pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
mridulm commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r827341070
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -639,7 +643,7 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameters(cls: Class[_]): Seq[(String, Type)] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
Review comment:
Is this limited only to `selfType` ?
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -653,10 +657,37 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameterNames(cls: Class[_]): Seq[String] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
constructParams(t).map(_.name.decodedName.toString)
}
+ /**
+ * Workaround for [[https://github.com/scala/bug/issues/12190 Scala bug #12190]]
+ *
+ * `ClassSymbol.selfType` can throw an exception in case of cyclic annotation reference
+ * in Java classes. A retry of this operation will succeed as the class which defines the
+ * cycle is now resolved. It can however expose further recursive annotation references, so
+ * we keep retrying until we exhaust our retry threshold.
+ */
+ @tailrec
+ private def selfType(clsSymbol: ClassSymbol, tries: Int = 5): Type = {
Review comment:
Update comment on why `5` ? (essentially `> 1` I guess is what we need ?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35852:
URL: https://github.com/apache/spark/pull/35852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r827486338
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -639,7 +643,7 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameters(cls: Class[_]): Seq[(String, Type)] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
Review comment:
Unfortunately, I do not have the technical knowhow to answer this question. What I can say is that `ScalaReflection` also uses `ClassSymbol.companion` which seems to work fine in this case. `ClassSymbol.annotations` fails, as might be expected, but it is not used anywhere in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1068303273
cc: @cloud-fan @HyukjinKwon @gengliangwang @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r827486883
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -653,10 +657,37 @@ object ScalaReflection extends ScalaReflection {
def getConstructorParameterNames(cls: Class[_]): Seq[String] = {
val m = runtimeMirror(cls.getClassLoader)
val classSymbol = m.staticClass(cls.getName)
- val t = classSymbol.selfType
+ val t = selfType(classSymbol)
constructParams(t).map(_.name.decodedName.toString)
}
+ /**
+ * Workaround for [[https://github.com/scala/bug/issues/12190 Scala bug #12190]]
+ *
+ * `ClassSymbol.selfType` can throw an exception in case of cyclic annotation reference
+ * in Java classes. A retry of this operation will succeed as the class which defines the
+ * cycle is now resolved. It can however expose further recursive annotation references, so
+ * we keep retrying until we exhaust our retry threshold.
+ */
+ @tailrec
+ private def selfType(clsSymbol: ClassSymbol, tries: Int = 5): Type = {
Review comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071085050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1073027300
Merged to master (3.4.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1068091019
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 edited a comment on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 edited a comment on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071260796
> How far back should this probably back-port? 3.1?
The issue itself is reproducible all the way back to 2.3 (at least). But I don't think this is too critical since `.selfType` only ever gets used when you try to fetch the JSON representation of the SQL plan using `TreeNode.toJSON` or `TreeNode.prettyJSON` AND if the plan uses Hive UDFs. It has remained unreported all this while, which points to low usage. So I think it is okay for this to only be committed to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071260796
> How far back should this probably back-port? 3.1?
The issue itself is reproducible all the way back to 2.3. But I don't this is too critical since `.selfType` only ever gets used when you try to fetch the JSON representation of the SQL plan using `TreeNode.toJSON` or `TreeNode.prettyJSON` AND if the plan uses Hive UDFs. It has remained unreported all this while, which points to low usage. So I think it is okay for this to only be committed to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071085050
@mridulm @srowen Mind taking a second look here? I have updated the PR as per the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 commented on a change in pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r826259921
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveScalaReflectionSuite.scala
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.ScalaReflection
+
+/**
+ * This test suite prefers to have its own JVM as the error for cyclic annotation references may
+ * not be thrown if the annotation class is previously loaded by some other test and so may be
+ * dependent on test execution order
+ */
+class HiveScalaReflectionSuite extends SparkFunSuite {
+
+ test("SPARK-38510: ScalaReflection.getConstructorParameterNames should work for classes with" +
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on a change in pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
xkrogen commented on a change in pull request #35852:
URL: https://github.com/apache/spark/pull/35852#discussion_r826255400
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveScalaReflectionSuite.scala
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.ScalaReflection
+
+/**
+ * This test suite prefers to have its own JVM as the error for cyclic annotation references may
+ * not be thrown if the annotation class is previously loaded by some other test and so may be
+ * dependent on test execution order
+ */
+class HiveScalaReflectionSuite extends SparkFunSuite {
+
+ test("SPARK-38510: ScalaReflection.getConstructorParameterNames should work for classes with" +
Review comment:
minor nit: space at the end of this line (`with"` -> `"with "`), current test name will have `withcyclic` in it
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveScalaReflectionSuite.scala
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.sql.catalyst.ScalaReflection
+
+/**
+ * This test suite prefers to have its own JVM as the error for cyclic annotation references may
+ * not be thrown if the annotation class is previously loaded by some other test and so may be
+ * dependent on test execution order
+ */
+class HiveScalaReflectionSuite extends SparkFunSuite {
+
+ test("SPARK-38510: ScalaReflection.getConstructorParameterNames should work for classes with" +
Review comment:
minor nit: add space at the end of this line (`with"` -> `"with "`), current test name will have `withcyclic` in it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 edited a comment on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 edited a comment on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071260796
> How far back should this probably back-port? 3.1?
The issue itself is reproducible all the way back to 2.3. But I don't think this is too critical since `.selfType` only ever gets used when you try to fetch the JSON representation of the SQL plan using `TreeNode.toJSON` or `TreeNode.prettyJSON` AND if the plan uses Hive UDFs. It has remained unreported all this while, which points to low usage. So I think it is okay for this to only be committed to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shardulm94 edited a comment on pull request #35852: [SPARK-38510][SQL] Retry ClassSymbol.selfType to work around cyclic references
Posted by GitBox <gi...@apache.org>.
shardulm94 edited a comment on pull request #35852:
URL: https://github.com/apache/spark/pull/35852#issuecomment-1071260796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org