[GitHub] [iceberg] nastra commented on a diff in pull request #8173: Core: Add table metadata supplier to allow lazy loading of metadata

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #8173:
URL: https://github.com/apache/iceberg/pull/8173#discussion_r1277219904


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -274,6 +275,59 @@ public String toString() {
       Map<String, SnapshotRef> refs,
       List<StatisticsFile> statisticsFiles,
       List<MetadataUpdate> changes) {
+    this(
+        metadataFileLocation,
+        formatVersion,
+        uuid,
+        location,
+        lastSequenceNumber,
+        lastUpdatedMillis,
+        lastColumnId,
+        currentSchemaId,
+        schemas,
+        defaultSpecId,
+        specs,
+        lastAssignedPartitionId,
+        defaultSortOrderId,
+        sortOrders,
+        properties,
+        currentSnapshotId,
+        snapshots,
+        snapshotsSupplier,
+        snapshotLog,
+        previousFiles,
+        refs,
+        statisticsFiles,
+        changes,
+        null);

Review Comment:
   this is mainly so that we don't have to update a bunch of tests that use this constructor signature



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org