You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "rovarga (via GitHub)" <gi...@apache.org> on 2025/08/30 14:56:16 UTC
[PR] Fix pekkoImport() range [pekko]
rovarga opened a new pull request, #2111:
URL: https://github.com/apache/pekko/pull/2111
The range does not reflect current version, update it to [2,2.1).
Signed-off-by: Robert Varga <ro...@pantheon.tech>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2111:
URL: https://github.com/apache/pekko/pull/2111#issuecomment-3239407566
@rovarga it would be good to keep the version change in its own PR instead of merging other changes here - we may end up cherry picking some changes to other version branches but we can't do that if you change version.
My suggestion is to leave this as version change only and to look at the comments that we have raised about the version strings. Reopen #2112 and use that for all the import fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2111:
URL: https://github.com/apache/pekko/pull/2111#issuecomment-3491563715
@rovarga I'm going to close this due to https://github.com/apache/pekko/pull/2313
Feel free to reopen this or raise an issue if that is insufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2111:
URL: https://github.com/apache/pekko/pull/2111#discussion_r2311987253
##########
project/OSGi.scala:
##########
@@ -143,7 +143,7 @@ object OSGi {
"!scala.util.parsing.*",
scalaImport(scalaVersion),
"*")
- def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "1.1", "1.2")
+ def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "2", "2.1")
Review Comment:
https://github.com/apache/pekko/pull/705 - but let's assume that that is not agreed yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #2111:
URL: https://github.com/apache/pekko/pull/2111#discussion_r2311981979
##########
project/OSGi.scala:
##########
@@ -143,7 +143,7 @@ object OSGi {
"!scala.util.parsing.*",
scalaImport(scalaVersion),
"*")
- def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "1.1", "1.2")
+ def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "2", "2.1")
Review Comment:
btw, I'm not sure if we should still keep osgi in 2.0.0, at least Akka dropped it and seems no much complain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #2111:
URL: https://github.com/apache/pekko/pull/2111#discussion_r2311981307
##########
project/OSGi.scala:
##########
@@ -143,7 +143,7 @@ object OSGi {
"!scala.util.parsing.*",
scalaImport(scalaVersion),
"*")
- def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "1.1", "1.2")
+ def pekkoImport(packageName: String = "org.apache.pekko.*") = versionedImport(packageName, "2", "2.1")
Review Comment:
2.0, 2.1 might be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Fix pekkoImport() range [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed pull request #2111: Fix pekkoImport() range
URL: https://github.com/apache/pekko/pull/2111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org