You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/06/29 20:58:55 UTC

Review Request 36014: Fixed stack trace in isolator tests on Linux VM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36014/
-----------------------------------------------------------

Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Bugs: MESOS-2956
    https://issues.apache.org/jira/browse/MESOS-2956


Repository: mesos


Description
-------

Fixed stack trace in isolator tests on Linux VM


Diffs
-----

  src/tests/isolator_tests.cpp 525a5a88b8ab0681a89c5f7451d9ca9031c793af 

Diff: https://reviews.apache.org/r/36014/diff/


Testing
-------

sudo make check


Thanks,

Paul Brett


Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36014/#review89775
-----------------------------------------------------------

Ship it!


Ship It!

- Ian Downes


On June 29, 2015, 11:58 a.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36014/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 11:58 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2956
>     https://issues.apache.org/jira/browse/MESOS-2956
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed stack trace in isolator tests on Linux VM
> 
> 
> Diffs
> -----
> 
>   src/tests/isolator_tests.cpp 525a5a88b8ab0681a89c5f7451d9ca9031c793af 
> 
> Diff: https://reviews.apache.org/r/36014/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36014/#review89795
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36014]

All tests passed.

- Mesos ReviewBot


On June 29, 2015, 6:58 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36014/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 6:58 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2956
>     https://issues.apache.org/jira/browse/MESOS-2956
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed stack trace in isolator tests on Linux VM
> 
> 
> Diffs
> -----
> 
>   src/tests/isolator_tests.cpp 525a5a88b8ab0681a89c5f7451d9ca9031c793af 
> 
> Diff: https://reviews.apache.org/r/36014/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>