You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "SpriCoder (via GitHub)" <gi...@apache.org> on 2026/06/09 12:31:38 UTC
[PR] Drop CMAKE_CURRENT_SOURCE_DIR from tsfile-cli include dirs [tsfile]
SpriCoder opened a new pull request, #835:
URL: https://github.com/apache/tsfile/pull/835
## Summary
- Replace `${CMAKE_CURRENT_SOURCE_DIR}` with `${CMAKE_SOURCE_DIR}/tools` in `cpp/tools/CMakeLists.txt`, for both the `tsfile_cli_obj` object library and the `tsfile_cli` executable. Addresses post-merge review feedback on #829.
- Matches the existing convention in `cpp/test/CMakeLists.txt`, which already uses `${CMAKE_SOURCE_DIR}/tools` for tool headers. Tool-own headers (`cli/`, `commands/`, `format/`) still resolve; library headers continue to come from the staged include tree.
## Test plan
- [x] Debug build (`-DENABLE_ANTLR4=OFF`): `tsfile` library + `tsfile_cli` compile and link; all headers resolve from the staged include tree.
- [x] `tsfile-cli --version` / `--help` run correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Drop CMAKE_CURRENT_SOURCE_DIR from tsfile-cli include dirs [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #835:
URL: https://github.com/apache/tsfile/pull/835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org