You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "xiazcy (via GitHub)" <gi...@apache.org> on 2023/04/20 06:10:32 UTC
[GitHub] [tinkerpop] xiazcy opened a new pull request, #2034: TINKERPOP-2925 mergeE() in javascript producing an error
xiazcy opened a new pull request, #2034:
URL: https://github.com/apache/tinkerpop/pull/2034
https://issues.apache.org/jira/browse/TINKERPOP-2925
Issue in gremlin-javascript arose due to Direction aliases `from_` and `to` not properly returning `Direction.OUT` and `Direction.IN`.
Also found similar issue in gremlin-python, where `Direction.from_` and `Direction.to` were not added to the `Direction` enum. They can now be used directly without the need to declare `from_ = Direction.OUT` and `to = Direction.IN`.
The existing Gherkin test as `g_mergeEXlabel_knows_out_marko_in_vadasX_aliased_direction` covers the case, although customized alias maps in feature-steps masked the issue in python and javascript, which are now removed.
This issue doesn't seem to appear in gremlin-go and gremlin-dotnet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2034: TINKERPOP-2925 mergeE() in javascript producing an error
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1518251457
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2034: TINKERPOP-2925 mergeE() in javascript producing an error
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1518394852
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #2034: TINKERPOP-2925 mergeE() in javascript producing an error
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2034: TINKERPOP-2925 mergeE() in javascript producing an error
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1515777604
## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2034?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2034](https://codecov.io/gh/apache/tinkerpop/pull/2034?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7331a7) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/d0e02f1e48635316794593d71f4517c996825221?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0e02f1) will **decrease** coverage by `4.89%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d7331a7 differs from pull request most recent head 92ea4e4. Consider uploading reports for the commit 92ea4e4 to get more accurate results
```diff
@@ Coverage Diff @@
## 3.6-dev #2034 +/- ##
=============================================
- Coverage 69.39% 64.51% -4.89%
=============================================
Files 878 25 -853
Lines 42103 3793 -38310
Branches 5643 0 -5643
=============================================
- Hits 29219 2447 -26772
+ Misses 10891 1179 -9712
+ Partials 1993 167 -1826
```
[see 853 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2034/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2034: TINKERPOP-2925 mergeE() in javascript producing an error
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1516591956
LGTM, VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org