You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/11 20:48:58 UTC

[GitHub] [arrow] nevi-me commented on pull request #9454: ARROW-11572: [Rust] Add a kernel for division by single scalar

nevi-me commented on pull request #9454:
URL: https://github.com/apache/arrow/pull/9454#issuecomment-777779826


   This is a good change, thanks @abreis.
   
   I think adding scalar equivalents to functions where we've previously converted scalars to arrays, ties us up in the future.
   
   The C++ implementation solves this issue by using a `Datum` that's loosely:
   
   ```rust
   enum Datum {
     Array(ArrayRef),
     Scalar(ScalarRef)
   }
   ```
   
   This would allow us to avoid `{kernel}_scalar` for all our kernels where 2 or more arrays are currently taken as inputs.
   
   What are your thoughts @jorgecarleitao @alamb @andygrove @ritchie46?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org