You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tomee.apache.org by "Daniel Kasmeroglu (JIRA)" <ji...@apache.org> on 2014/10/13 03:14:33 UTC

[jira] [Created] (TOMEE-1401) Invalid module lookup of OpenEJBDeploymentManager

Daniel Kasmeroglu created TOMEE-1401:
----------------------------------------

             Summary: Invalid module lookup of OpenEJBDeploymentManager
                 Key: TOMEE-1401
                 URL: https://issues.apache.org/jira/browse/TOMEE-1401
             Project: TomEE
          Issue Type: Bug
    Affects Versions: 2.0.0
            Reporter: Daniel Kasmeroglu
             Fix For: 2.0.0


There is an error in the following methods:

* getAvailableModules
* getRunningModules
* getNonRunningModules

The error makes the parameter _moduleType_ useless as it's basically ignored. I suspect that this is the result of an incomplete refactoring attempt.
See:

https://kasisoft.com/stash/projects/TOMEE/repos/tomee/commits/b10129e0f66277e003c7ed9f5912faf1f4c65b78

Apart from that these methods are basically all equal so they could be combined into a single method (I didn't do that to keep the diff readable).




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)