[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #9379: [fix][compaction] Rowset::end_version null pointer

[GitBox <gi...@apache.org>]

xinyiZzz commented on code in PR #9379:
URL: https://github.com/apache/incubator-doris/pull/9379#discussion_r865737746


##########
be/src/olap/compaction.cpp:
##########
@@ -136,7 +136,12 @@ Status Compaction::do_compaction_impl(int64_t permits) {
     int64_t current_max_version;
     {
         std::shared_lock rdlock(_tablet->get_header_lock());
-        current_max_version = _tablet->rowset_with_max_version()->end_version();

Review Comment:
   This seems to happen in two cases:
   1. The tablet has no rowset.
   2. The version of max version rowset no longer exists in the tablet.
   
   In fact, I did not carefully analyze why it occurs. Because other `tablet->rowset_with_max_version()` all compare whether the return value is null, so I also compare here :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org